Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Can we remove bignumber.js and use instead the one provided by web3 #940

Closed
nicosampler opened this issue May 21, 2020 · 3 comments
Closed

Can we remove bignumber.js and use instead the one provided by web3 #940

nicosampler opened this issue May 21, 2020 · 3 comments
Labels
Tech-debt 🚧 Technical debt
Milestone
Sprint 8 "Lion's ...

Comments

@nicosampler
Copy link
Contributor

No description provided.

@nicosampler nicosampler added the Tech-debt 🚧 Technical debt label May 21, 2020
@nicosampler nicosampler added this to the Sprint 8 "Lion's Head" milestone May 21, 2020
@mmv08
Copy link
Member

mmv08 commented May 21, 2020

web3/web3.js#2171

keep in mind that bn.js (used by web3) and bignumber.js are different libs

@nicosampler
Copy link
Contributor Author

you right, but perhaps we can use bignumber instead, I didn't analyze why we are using bn.

@katspaugh
Copy link
Member

BigNumber is atm used in a large number of our files.
@nicosampler what would be the benefits of switching to web3.BN apart from the bundle size?
Also consider that Webpack tree shaking will probably optimize this anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Tech-debt 🚧 Technical debt
Projects
None yet
Milestone
Sprint 8 "Lion's Head"
Development

No branches or pull requests
3 participants
@katspaugh @nicosampler @mmv08