Skip to content

Commit 16fa963

Browse files
AndreaCuneoAndreaCuneo
committed
chore: add ConfigureAwait(false) to libraries
1 parent ae068ed commit 16fa963

File tree

169 files changed

+1144
-800
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

169 files changed

+1144
-800
lines changed

Diff for: ‎.editorconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ dotnet_diagnostic.MA0160.severity = warning
273273
dotnet_diagnostic.CA2020.severity = warning
274274
dotnet_diagnostic.MA0032.severity = none
275275
dotnet_diagnostic.MA0040.severity = error
276-
dotnet_diagnostic.MA0004.severity = suggestion
276+
dotnet_diagnostic.MA0004.severity = warning
277277
dotnet_diagnostic.MA0043.severity = warning
278278
dotnet_diagnostic.MA0079.severity = error
279279
dotnet_diagnostic.MA0080.severity = warning

Diff for: ‎Ark.ReferenceProject/.editorconfig

+5-1
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ dotnet_diagnostic.MA0160.severity = warning
273273
dotnet_diagnostic.CA2020.severity = warning
274274
dotnet_diagnostic.MA0032.severity = none
275275
dotnet_diagnostic.MA0040.severity = error
276-
dotnet_diagnostic.MA0004.severity = suggestion
276+
dotnet_diagnostic.MA0004.severity = none
277277
dotnet_diagnostic.MA0043.severity = warning
278278
dotnet_diagnostic.MA0079.severity = error
279279
dotnet_diagnostic.MA0080.severity = warning
@@ -291,6 +291,10 @@ dotnet_diagnostic.MA0056.severity = silent
291291
dotnet_diagnostic.MA0049.severity = none
292292
dotnet_diagnostic.MA0007.severity = silent
293293

294+
# IDE0290: Use primary constructor
295+
dotnet_diagnostic.IDE0290.severity = none
296+
dotnet_diagnostic.MA0003.severity = none
297+
294298
[*.{cs,vb}]
295299
dotnet_style_operator_placement_when_wrapping = beginning_of_line
296300
tab_width = 4

Diff for: ‎Ark.ReferenceProject/Ark.Reference.Common/Auth/RequiredScopePolicyHandler.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace Ark.Reference.Common.Auth
1010
public abstract class RequiredScopePolicyHandler : AuthorizationHandler<RequiredScopePolicy>
1111
{
1212
private readonly string _serviceScope;
13-
private static readonly char[] _separator = new[] { ' ' };
13+
private static readonly char[] _separator = [' '];
1414

1515
protected RequiredScopePolicyHandler(
1616
string serviceScope)

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Application/Handlers/Messages/MessageCounter.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
namespace Ark.Reference.Core.Application
1+
namespace Ark.Reference.Core.Application.Handlers.Messages
22
{
33
public static class MessageCounter
44
{

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Application/Handlers/Queries/Ping_GetByFiltersHandler.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
using Ark.Tools.Core;
1212

13-
namespace Core.Services.Application.Handlers.Queries
13+
namespace Ark.Reference.Core.Application.Handlers.Queries
1414
{
1515
public class Ping_GetByFiltersHandler : IQueryHandler<Ping_GetByFiltersQuery.V1, PagedResult<Ping.V1.Output>>
1616
{

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Application/Handlers/Queries/Ping_GetByIdHandler.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
using System.Threading;
99
using System.Threading.Tasks;
1010

11-
namespace Core.Services.Application.Handlers.Queries
11+
namespace Ark.Reference.Core.Application.Handlers.Queries
1212
{
1313
public class Ping_GetIdHandler : IQueryHandler<Ping_GetByIdQuery.V1, Ping.V1.Output?>
1414
{

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Application/Handlers/Requests/Ping_CreateAndSendMsgRequestHandler.cs

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
using System.Security.Claims;
1414
using System.Threading;
1515
using System.Threading.Tasks;
16+
using Ark.Reference.Core.Application.Handlers.Messages;
1617

1718
namespace Ark.Reference.Core.Application.Handlers.Requests
1819
{

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Application/Host/ApiHost.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ public class ApiHost
5555
public ApiHost(IApiHostConfig config)
5656
{
5757
this.Config = config;
58-
this._applicationAssemblies = new Assembly[] {
58+
this._applicationAssemblies = [
5959
typeof(ApiHost).Assembly
60-
};
60+
];
6161
this.Container = new Container();
6262
}
6363

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Common/ApplicationConstants.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
{
33
public class ApplicationConstants
44
{
5-
public static readonly string[] Versions = {
5+
public static readonly string[] Versions = [
66
"1.0"
7-
};
7+
];
88
}
99
}

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Common/UrlComposer.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace Ark.Reference.Core.Common
1111
public class UrlComposer
1212
{
1313
private readonly string _baseUrl = "";
14-
private readonly List<(string key, string value)> _tuples = new List<(string key, string value)>();
14+
private readonly List<(string key, string value)> _tuples = new();
1515
private static readonly LocalDatePattern _localDatePattern = LocalDatePattern.Iso;
1616
private static readonly LocalDateTimePattern _localDateTimePattern = LocalDateTimePattern.GeneralIso;
1717

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Tests/Auth/AuthTestContext.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public class AuthTestContext
3131
;
3232

3333
private string _scopeClaim = AuthConstants.ScopePrefix;
34-
private List<string> _scopes = new List<string>();
34+
private List<string> _scopes = new();
3535

3636
public AuthTestContext()
3737
{

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Tests/Auth/JwtTokenBuilder.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ public JwtToken Build()
7070

7171
var claims = new List<Claim>
7272
{
73-
new Claim(JwtRegisteredClaimNames.Sub, this._subject),
74-
new Claim(JwtRegisteredClaimNames.Jti, Guid.NewGuid().ToString())
73+
new(JwtRegisteredClaimNames.Sub, this._subject),
74+
new(JwtRegisteredClaimNames.Jti, Guid.NewGuid().ToString())
7575
}
7676
.Union(this._claims);
7777

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Tests/Init/DatabaseUtils.cs

+23-33
Original file line numberDiff line numberDiff line change
@@ -20,28 +20,22 @@ sealed class DatabaseUtils
2020
[BeforeTestRun(Order = -1)]
2121
public static async Task CreateNLogDatabaseIfNotExists()
2222
{
23-
await using (var conn = new SqlConnection(DatabaseConnectionString))
24-
{
25-
await conn.OpenAsync();
26-
await using (var cmd = new SqlCommand($"IF (db_id(N'Logs') IS NULL) BEGIN CREATE DATABASE [Logs] END;", conn))
27-
{
28-
await cmd.ExecuteNonQueryAsync();
29-
}
30-
}
23+
await using var conn = new SqlConnection(DatabaseConnectionString);
24+
await conn.OpenAsync();
25+
await using var cmd = new SqlCommand($"IF (db_id(N'Logs') IS NULL) BEGIN CREATE DATABASE [Logs] END;", conn);
26+
await cmd.ExecuteNonQueryAsync();
3127
}
3228

3329
[BeforeTestRun(Order = -1)]
3430
public static void DeployDB()
3531
{
3632
var instance = new DacServices(DatabaseConnectionString);
37-
using (var dacpac = DacPackage.Load("Ark.Reference.Core.Database.dacpac"))
33+
using var dacpac = DacPackage.Load("Ark.Reference.Core.Database.dacpac");
34+
instance.Deploy(dacpac, "Ark.Reference.Core.Database", true, new DacDeployOptions()
3835
{
39-
instance.Deploy(dacpac, "Ark.Reference.Core.Database", true, new DacDeployOptions()
40-
{
41-
CreateNewDatabase = true,
42-
AllowIncompatiblePlatform = true // needed since Database project is AzureV12 and under tests 2022 is used
43-
});
44-
}
36+
CreateNewDatabase = true,
37+
AllowIncompatiblePlatform = true // needed since Database project is AzureV12 and under tests 2022 is used
38+
});
4539
}
4640

4741
[BeforeScenario]
@@ -59,26 +53,22 @@ public async Task CleanUpEntireDbBeforeScenario(FeatureContext fctx, ScenarioCon
5953

6054
private async Task _cleanUpEntireDb(bool resetProfileCalendar = false)
6155
{
62-
await using (var ctx = new SqlConnection(TestHost.DBConfig.ConnectionString))
63-
{
64-
await ctx.OpenAsync();
65-
await using (var tx = await ctx.BeginTransactionAsync())
66-
{
56+
await using var ctx = new SqlConnection(TestHost.DBConfig.ConnectionString);
57+
await ctx.OpenAsync();
58+
await using var tx = await ctx.BeginTransactionAsync();
6759

68-
await ctx.ExecuteAsync(
69-
@"[ops].[ResetFull_onlyForTesting]",
70-
new
71-
{
72-
areYouReallySure = true,
73-
resetConfig = true,
74-
},
75-
commandType: CommandType.StoredProcedure,
76-
commandTimeout: 60,
77-
transaction: tx);
60+
await ctx.ExecuteAsync(
61+
@"[ops].[ResetFull_onlyForTesting]",
62+
new
63+
{
64+
areYouReallySure = true,
65+
resetConfig = true,
66+
},
67+
commandType: CommandType.StoredProcedure,
68+
commandTimeout: 60,
69+
transaction: tx);
7870

79-
await tx.CommitAsync();
80-
}
81-
}
71+
await tx.CommitAsync();
8272
}
8373
}
8474
}

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Tests/Init/TestHost.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public sealed class TestHost : IDisposable
5252
public static ArkFlurlClientFactory Factory { get => _factory ?? throw new InvalidOperationException("_server is null"); set => _factory = value; }
5353

5454
private static ArkFlurlClientFactory? _factory;
55-
public static readonly TestEnv Env = new TestEnv();
55+
public static readonly TestEnv Env = new();
5656

5757
private static ScenarioContext? _scenarioContext;
5858
private static IHost? _server;
@@ -185,7 +185,7 @@ public static void BeforeTests()
185185

186186
//ApplicationConstants.ComputeIdleDetectWindow = TimeSpan.FromSeconds(1);
187187

188-
var builder = Program.GetHostBuilder(Array.Empty<string>())
188+
var builder = Program.GetHostBuilder([])
189189
.ConfigureWebHost(wh =>
190190
{
191191
wh.UseTestServer()
@@ -274,9 +274,9 @@ public TestEnv()
274274
TestDataFilePath = Path.GetDirectoryName(AppContext.BaseDirectory) + @"\TestData\";
275275
}
276276

277-
public ClaimsPrincipal TestPrincipal { get; } = new ClaimsPrincipal(new ClaimsIdentity(new[]{
277+
public ClaimsPrincipal TestPrincipal { get; } = new ClaimsPrincipal(new ClaimsIdentity([
278278
new Claim(ClaimTypes.NameIdentifier, "Specflow")
279-
}, "SYSTEM"));
279+
], "SYSTEM"));
280280

281281
public InMemNetwork RebusNetwork { get; } = new InMemNetwork(true);
282282
public InMemorySubscriberStore RebusSubscriber { get; } = new InMemorySubscriberStore();

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.Tests/TestClient.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public void Get(string requestUri, EntityTagHeaderValue? e)
7575

7676
public void Get(string[] requestUriParts, EntityTagHeaderValue? e)
7777
{
78-
var req = _client.Request(new[] { _version });
78+
var req = _client.Request([_version]);
7979

8080
foreach (var part in requestUriParts)
8181
req.AppendPathSegment(part, true);

Diff for: ‎Ark.ReferenceProject/Core/Ark.Reference.Core.WebInterface/Startup.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public class Startup : ArkStartupWebApi
3535
public override IEnumerable<ApiVersion> Versions => ApplicationConstants.Versions.Reverse().Select(x => ApiVersionParser.Default.Parse(x));
3636

3737
public override OpenApiInfo MakeInfo(ApiVersion version)
38-
=> new OpenApiInfo
38+
=> new()
3939
{
4040
Title = "Core Service API",
4141
Version = version.ToString("VVVV", CultureInfo.InvariantCulture),

Diff for: ‎Ark.Tools.Activity/Processor/Rebus/RebusSliceActivityManager.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace Ark.Tools.Activity.Processor
2222
public sealed class RebusSliceActivityManager<TActivity> : ISliceActivityManager<TActivity>, IDisposable where TActivity : class, ISliceActivity
2323
{
2424

25-
private readonly Container _container = new Container();
25+
private readonly Container _container = new();
2626
private readonly string _name;
2727
private readonly IEnumerable<Resource> _dependencies;
2828
private readonly Func<TActivity> _activityFactory;
@@ -82,7 +82,7 @@ public async Task Start()
8282
var bus = _container.GetInstance<IBus>();
8383
foreach (var d in _dependencies)
8484
{
85-
await bus.Advanced.Topics.Subscribe(d.ToString());
85+
await bus.Advanced.Topics.Subscribe(d.ToString()).ConfigureAwait(false);
8686
}
8787
}
8888
}

Diff for: ‎Ark.Tools.Activity/Processor/Rebus/SliceActivitySaga.cs

+6-6
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ public async Task Handle(SliceReady message)
4545
{
4646
if (_activity.CoolDown == null || Data.IsCoolDown == false)
4747
{
48-
await _process();
48+
await _process().ConfigureAwait(false);
4949
}
5050
else if (Data.IsCoolDown && !Data.IsScheduled)
5151
{
52-
await _schedule(message);
52+
await _schedule(message).ConfigureAwait(false);
5353
}
5454
else
5555
{
@@ -76,17 +76,17 @@ public Task Handle(Tasks.Messages.SliceReady message)
7676
public async Task Handle(CoolDownMessage message)
7777
{
7878
_activity.Logger.Info("Message Processed after CoolDown Time for Slice {ActivitySlice}", Data.ActivitySlice);
79-
await _process();
79+
await _process().ConfigureAwait(false);
8080
}
8181

8282
private async Task _process()
8383
{
84-
await _activity.Process(Data.ActivitySlice);
84+
await _activity.Process(Data.ActivitySlice).ConfigureAwait(false);
8585
await _bus.Advanced.Topics.Publish(_activity.Resource.ToString(), new ResourceSliceReady()
8686
{
8787
Resource = _activity.Resource,
8888
Slice = Data.ActivitySlice
89-
});
89+
}).ConfigureAwait(false);
9090
_activity.Logger.Info("Completed materialization for slice {ActivitySlice}.", Data.ActivitySlice);
9191

9292
// Reset CD
@@ -110,7 +110,7 @@ private async Task _schedule(SliceReady message)
110110
ActivitySlice = Slice.From(message.ActivitySlice.SliceStart),
111111
Resource = Resource.Create(message.Resource.Provider, message.Resource.Id),
112112
ResourceSlice = Slice.From(message.ResourceSlice.SliceStart)
113-
});
113+
}).ConfigureAwait(false);
114114

115115
Data.IsScheduled = true;
116116
}

Diff for: ‎Ark.Tools.Activity/Provider/Rebus/RebusResourceNotifier.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class RebusResourceNotifier : IResourceNotifier, IDisposable
2121
private static Logger _logger = LogManager.GetCurrentClassLogger();
2222
private bool _disposedValue;
2323
private readonly string _providerName;
24-
private readonly Container _container = new Container();
24+
private readonly Container _container = new();
2525

2626
public RebusResourceNotifier(IRebusResourceNotifier_Config config)
2727
{

Diff for: ‎Ark.Tools.Activity/ResourceDependency.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public static ResourceDependency OneSlice(Resource resource, Func<Slice, Slice>
1919
{
2020
return new ResourceDependency() {
2121
Resource = resource,
22-
_getDependentSlice = s => new[] { getDependentSourceSlice(s) }
22+
_getDependentSlice = s => [getDependentSourceSlice(s)]
2323
};
2424
}
2525

0 commit comments

Comments
 (0)