Refactor NhlGameService and update PlayerTests

Refactored NhlGameService to use concise object initialization with `new()` syntax for `_nhlScoresHtmlReportsApiHttpClient`. Changed `CalculateMultiplier` to a private static method. Added a `default` case in `PlayerTests` switch statement to throw `ArgumentException` for unmatched `query` values.

Author: Afischbacher

Nhl.Api.Domain/Services/NhlGameService.cs

@@ -27,7 +27,7 @@ public interface INhlGameService
 /// </summary>
 public class NhlGameService : INhlGameService
 {
-    private readonly INhlApiHttpClient _nhlScoresHtmlReportsApiHttpClient = new NhlScoresHtmlReportsApiHttpClient();
+    private readonly NhlScoresHtmlReportsApiHttpClient _nhlScoresHtmlReportsApiHttpClient = new();
 
     /// <summary>
     /// A method to add the estimated time of play for each play in the game center play by play
@@ -167,7 +167,7 @@ public async Task<GameCenterPlayByPlay> AddEstimatedDateTimeOfPlayForEachPlay(Ga
                     var distanceBetweenPlays = endTime - startTime;
                     var timeBetweenPlays = distanceBetweenPlays / playsForPeriod.Value.Count;
 
-                    var multiplier = this.CalculateMultiplier(startTime, endTime, playsForPeriod.Value.Count);
+                    var multiplier = CalculateMultiplier(startTime, endTime, playsForPeriod.Value.Count);
                     for (var i = 0; i < playsForPeriod.Value.Count; i++)
                     {
                         var play = playsForPeriod.Value[i];
@@ -192,9 +192,8 @@ public async Task<GameCenterPlayByPlay> AddEstimatedDateTimeOfPlayForEachPlay(Ga
     /// <param name="endTime">The end time of the period</param>
     /// <param name="events">The number of events in the period</param>
     /// <returns>A multiplier value for time distribution calculations</returns>
-    private double CalculateMultiplier(DateTime startTime, DateTime endTime, int events)
+    private static double CalculateMultiplier(DateTime startTime, DateTime endTime, int events)
     {
-
         // Constants for the multiplier formula
         var DURATION_COEFFICIENT = 41.0;
         var EVENTS_COEFFICIENT = 2.0;

Nhl.Api.Tests/PlayerTests.cs

@@ -145,6 +145,9 @@ public async Task SearchAllActivePlayersAsync_Returns_Valid_Information(string q
                 Assert.AreEqual("6\u00274\"", playerSearchResult.Height);
                 Assert.AreEqual(31, playerSearchResult.PlayerNumber);
                 break;
+
+            default:
+                throw new ArgumentException(null, nameof(query));
         }
 
     }