Skip to content

(1.16) Optimise and clean-up tile entities #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2022
Merged

(1.16) Optimise and clean-up tile entities #4465

merged 5 commits into from
Apr 30, 2022

Conversation

Matyrobbrt
Copy link
Contributor

This PR optimises and cleans up tile entities by:

  • replacing if-chains with switch statements where possible
  • replacing new instances of Random with ThreadLocalRandom.current
  • replacing data types where necessary (ints with shorts)
  • removing unneeded local variables and fields

@Matyrobbrt Matyrobbrt marked this pull request as draft April 30, 2022 16:52
@Matyrobbrt Matyrobbrt marked this pull request as ready for review April 30, 2022 18:52
@Matyrobbrt Matyrobbrt marked this pull request as draft April 30, 2022 19:11
@Matyrobbrt Matyrobbrt marked this pull request as ready for review April 30, 2022 20:18
@Matyrobbrt
Copy link
Contributor Author

PR is ready for review.

@AlexModGuy AlexModGuy merged commit 72150fd into AlexModGuy:1.16.3 Apr 30, 2022
@sciwhiz12 sciwhiz12 mentioned this pull request May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matyrobbrt @AlexModGuy @PaintNinja