Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry Run Writes Updated package.json Version to Disk #25

Closed
mjhasbach opened this issue Oct 20, 2015 · 3 comments
Closed

Dry Run Writes Updated package.json Version to Disk #25

mjhasbach opened this issue Oct 20, 2015 · 3 comments

Comments

@mjhasbach
Copy link
Contributor

Dry running writes the updated package.json version to disk, necessitating a Git revert before the actual run. I was wondering if that was intentional, and if so, why, because the console also displays the updated version?

@AlexKVal
Copy link
Owner

Intentional.
And temporary folders with their respective content are not being deleted by script too.
That's for checking of all with dry run for complex project as React-Bootstrap.

E.g. in R-B documents site pages are being generated and via dry-run we are able to check
that all is OK before releasing npm, bower libs and publishing docs site.

We are reverting changes after dry-run back by simple command:
git checkout reset --hard

console could display the change, but an actual change could not be applied in reality (because of some subtle bug for example).

@mjhasbach
Copy link
Contributor Author

Cool, thanks

@AlexKVal
Copy link
Owner

You are welcome 🍒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants