Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks for bb8-v0.7, qp-v0.1.3 and qp-v0.2.0 deadlock #1

Open
bikeshedder opened this issue Apr 28, 2022 · 0 comments
Open

Benchmarks for bb8-v0.7, qp-v0.1.3 and qp-v0.2.0 deadlock #1

bikeshedder opened this issue Apr 28, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bikeshedder
Copy link
Contributor

I just found this repository and was curious to use this data to see if there is any optimization potential in deadpool. When running the benchmarks myself I ran into an interesting problem. Some of the benchmarks simply deadlock:

bb8-v0.7

rust-pool-benchmark/bb8-v0.7 on  main [!?] via 🦀 v1.60.0 
❯ cargo bench
    Finished bench [optimized] target(s) in 0.02s
     Running unittests (target/release/deps/bench_main-4d2bfb7599dace8c)
bb8-v0.7 (pool=4, worker=4): 8.361µs (Q1=8.079µs, Q3=8.876µs)
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: TimedOut', benches/bench_main.rs:55:64
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(4914), ...)', benches/bench_main.rs:63:34
error: bench failed

qp-v0.1.3

rust-pool-benchmark/qp-v0.1.3 on  main [!?] via 🦀 v1.60.0 
❯ cargo bench
    Finished bench [optimized] target(s) in 0.01s
     Running unittests (target/release/deps/bench_main-7b3924d4f7fae3c8)
qp-v0.1.3 (pool=4, worker=4): 8.946µs (Q1=8.628µs, Q3=9.47µs)

No output from that point onward. Checking the process manager I can see 0 CPU load for that process and all threads sleeping. So I can only assume it has deadlocked.

qp-v0.2.0

rust-pool-benchmark/qp-v0.2.0 on  main [!?] via 🦀 v1.60.0 
❯ cargo bench
    Finished bench [optimized] target(s) in 0.28s
     Running unittests (target/release/deps/bench_main-73eaede4d127b79a)
qp-v0.2.0 (pool=4, worker=4): 8.808µs (Q1=8.515µs, Q3=9.38µs)
(5 minutes later... still nothing...)

No output from that point onward. Checking the process manager I can see 0 CPU load for that process and all threads sleeping. So I can only assume it has deadlocked.

My system details:

❯ cat /proc/cpuinfo |grep "model name"|head -n 1
model name	: Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz

❯ cat /proc/meminfo |grep MemTotal
MemTotal:       131839000 kB

❯ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 21.10
Release:	21.10
Codename:	impish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants