Weird if-else condition and method not used #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

danipen opened this issue Apr 8, 2025 · 0 comments

Collaborator

danipen commented Apr 8, 2025 •

edited

Loading

Hey @grokys, I noticed a weird condition in SelectionNodeBase.cs: Both if-else conditions are returning an empty result.

Avalonia.Controls.TreeDataGrid/src/Avalonia.Controls.TreeDataGrid/Selection/SelectionNodeBase.cs

Lines 389 to 397 in 8fbb619

    
           if (selectedItemsMoved || unselectedItemsMoved) 
        
           { 
        
               var changes = new List<CollectionChangeState>(); 
        
               return changes; 
        
           } 
        
           else 
        
           { 
        
               return []; 
        
           }

But I also saw that the private method containing it isn't used anywhere.
Is it safe to remove it?

Thanks!

danipen changed the title ~~Same if-else and method not used~~ Weird if-else condition and method not used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment