From c38c7791436cdf3eef18a4ecb3f67303c2490636 Mon Sep 17 00:00:00 2001 From: Victoria Hall Date: Wed, 9 Oct 2024 09:41:43 -0500 Subject: [PATCH 1/4] allowing both BlobSource and string source values --- azure/functions/decorators/blob.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/azure/functions/decorators/blob.py b/azure/functions/decorators/blob.py index bd2861fa..eaad9220 100644 --- a/azure/functions/decorators/blob.py +++ b/azure/functions/decorators/blob.py @@ -17,7 +17,10 @@ def __init__(self, **kwargs): self.path = path self.connection = connection - self.source = source.value if source else None + if type(source) is BlobSource: + self.source = source.value if source else None + else: + self.source = source super().__init__(name=name, data_type=data_type) @staticmethod From a6b75ee21aa4f2f3e094fe63fbe250c95210f915 Mon Sep 17 00:00:00 2001 From: Victoria Hall Date: Wed, 9 Oct 2024 09:46:32 -0500 Subject: [PATCH 2/4] add test --- tests/decorators/test_blob.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/decorators/test_blob.py b/tests/decorators/test_blob.py index 43926591..bad8f99b 100644 --- a/tests/decorators/test_blob.py +++ b/tests/decorators/test_blob.py @@ -50,7 +50,7 @@ def test_blob_trigger_creation_with_source_as_string(self): trigger = BlobTrigger(name="req", path="dummy_path", connection="dummy_connection", - source=BlobSource.EVENT_GRID, + source="EventGrid", data_type=DataType.UNDEFINED, dummy_field="dummy") From 08cf646c98fed25087f35fe6998226d7488198ea Mon Sep 17 00:00:00 2001 From: Victoria Hall Date: Wed, 9 Oct 2024 10:09:03 -0500 Subject: [PATCH 3/4] using isinstance, removed extra if check --- azure/functions/decorators/blob.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/azure/functions/decorators/blob.py b/azure/functions/decorators/blob.py index eaad9220..e3de6f7c 100644 --- a/azure/functions/decorators/blob.py +++ b/azure/functions/decorators/blob.py @@ -17,8 +17,8 @@ def __init__(self, **kwargs): self.path = path self.connection = connection - if type(source) is BlobSource: - self.source = source.value if source else None + if isinstance(source, BlobSource): + self.source = source.value else: self.source = source super().__init__(name=name, data_type=data_type) From 9b5d36174bbf633a416c82616251c1fb1e0db35f Mon Sep 17 00:00:00 2001 From: Victoria Hall Date: Wed, 9 Oct 2024 10:26:15 -0500 Subject: [PATCH 4/4] mypy fix --- azure/functions/decorators/blob.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure/functions/decorators/blob.py b/azure/functions/decorators/blob.py index e3de6f7c..9ed4ce2f 100644 --- a/azure/functions/decorators/blob.py +++ b/azure/functions/decorators/blob.py @@ -20,7 +20,7 @@ def __init__(self, if isinstance(source, BlobSource): self.source = source.value else: - self.source = source + self.source = source # type: ignore super().__init__(name=name, data_type=data_type) @staticmethod