azure-quickstart-templates/quickstarts/microsoft.azurestackhci/create-cluster /azuredeploy.json needs update

[jscc-hv]

The template worked in the past and recently stopped working. Potentially due to Portal update

template 8-16

Even if the name is properly filled, the error check would not go away, and it prevents deployment.

After inspection, it is due to lack of conditional logic to make clusterWitnessStorageAccountName optional and skip creating a storage account although the template attempts to set a variable clusterWitnessStorageAccountNameVar to "" when witnessType is "No Witness", it never uses a condition on the storage account resource itself.

Suggested fix is to add "condition": "[equals(parameters('witnessType'), 'Cloud')]", to line 549

I can confirm that the conditional logic removes the error.

[rquarry]

@jscc-hv Pretty cool you detailed the fix. A lot of issues here seem to be, "this is broken....". I don't think anyone from Microsoft actually makes the updates in this repo. Since these are community provided examples/demos, the onus is on the public to provide updates via pull requests. Suggest you submit a pull request with the update you mentioned.