Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of Telemetry in models #29

Open
JMayrbaeurl opened this issue Mar 4, 2021 · 3 comments
Open

Usage of Telemetry in models #29

JMayrbaeurl opened this issue Mar 4, 2021 · 3 comments
Assignees

Comments

@JMayrbaeurl
Copy link
Contributor

A lot of models are using Telemetry attributes, even in cases where a Property attribute should be used. E.g. 'dtmi:digitaltwins:ngsi_ld:city:ParkingSpot;1' in 'Ontology\Parking\ParkingSpot\ParkingSpot.json'.

        {
            "@type": "Telemetry",
            "name": "status",
            "schema": {
                "@type": "Enum",
                "valueSchema": "string",
                "enumValues": [
                    {
                        "name": "occupied",
                        "displayName": "Occupied",
                        "enumValue": "occupied"
                    },
                    {
                        "name": "free",
                        "displayName": "Free",
                        "enumValue": "free"
                    },
                    {
                        "name": "closed",
                        "displayName": "Closed",
                        "enumValue": "closed"
                    },
                    {
                        "name": "unkown",
                        "displayName": "Unkown",
                        "enumValue": "unkown"
                    }
                ]
            }
        },

Why is 'status' a Telemetry attribute here? If used like this, you won't be able to query for free parking spots, since values of Telemetry attributes won't be stored.

@JMayrbaeurl
Copy link
Contributor Author

@gdetant Just added a PR #48 to fix this for the ParkingSpot entity

@JMayrbaeurl
Copy link
Contributor Author

See other usage of Telemetry in the ontology: Telemetry_Usage.txt

@gdetant
Copy link
Collaborator

gdetant commented Jun 11, 2021

I merged the PR 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants