Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contactPoint Property implemented as string? Why not using the structure from Schema.org #30

Open
JMayrbaeurl opened this issue Mar 5, 2021 · 3 comments
Assignees

Comments

@JMayrbaeurl
Copy link
Contributor

Hi,

Several models contain the property 'contactPoint', that is declared with the schema 'string' in all DTDL models (e.g. OffstreetParking.json). But the ETSI specification defines ContactPoint from Schema.org for the contactPoint properties. Shouldn't we replace the string with a dedicated ContactPoint model in the crossdomain folder?

@gdetant
Copy link
Collaborator

gdetant commented Mar 5, 2021

That is a good point. We don't have the complete set of schema.org, but we can model what we need of course

@JMayrbaeurl
Copy link
Contributor Author

BTW. Since we'll need Schema.org models quite often, I've created a dedicated repo for them. See e.g. ContactPoint.json.
@miriambrus Do we have plans for a generic base ontology for all our domain specific ontologies?

@JMayrbaeurl
Copy link
Contributor Author

As discussed with @miriambrus per e-mail, I've added ContactPoint from Schema.org with a PR #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants