Skip to content

Commit dadddcb

Browse files
addaleaxBridgeAR
authored andcommitted
tools: treat SIGABRT as crash
Otherwise, potentially no output is shown for aborts. PR-URL: nodejs#19990 Refs: nodejs#19903 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent 8e30589 commit dadddcb

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

tools/test.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -582,8 +582,7 @@ def HasCrashed(self):
582582
# Timed out tests will have exit_code -signal.SIGTERM.
583583
if self.output.timed_out:
584584
return False
585-
return self.output.exit_code < 0 and \
586-
self.output.exit_code != -signal.SIGABRT
585+
return self.output.exit_code < 0
587586

588587
def HasTimedOut(self):
589588
return self.output.timed_out;

0 commit comments

Comments
 (0)