Skip to content

Commit 15e57b8

Browse files
authored
Rollup merge of rust-lang#60366 - lzutao:patch-1, r=pietroalbini
build-gcc: Create missing cc symlink This PR mostly fixes build error caused by using rustc docker images to build [rustup][1] (with the error: ``linker `cc` not found``). I don't know why gcc build script doesn't install cc hard link by default. In build log, with `make SHELL='sh -x' install`, gcc build script installs c++ hard link but not `cc` one: ```bash if test "" != "yes" ; then \ rm -f /rustroot/bin/g++; \ /usr/bin/install -c xg++ /rustroot/bin/g++; \ chmod a+x /rustroot/bin/g++; \ rm -f /rustroot/bin/c++; \ ( cd /rustroot/bin && \ ln g++ c++ ); \ if [ -f cc1plus ] ; then \ if [ ! -f g++-cross ] ; then \ rm -f /rustroot/bin/x86_64-unknown-linux-gnu-g++; \ ( cd /rustroot/bin && \ ln g++ x86_64-unknown-linux-gnu-g++ ); \ rm -f /rustroot/bin/x86_64-unknown-linux-gnu-c++; \ ( cd /rustroot/bin && \ ln c++ x86_64-unknown-linux-gnu-c++ ); \ fi ; \ fi; \ fi ``` This might be fixed downstream by manually creating cc hard link or setting `RUSTFLAGS="-C linker=gcc"` as [suggested by @mati865][2]. But I find it better to fix it upstream in this PR. [1]: rust-lang/rustup#1815 [2]: rust-lang/rustup#1815 (comment)
2 parents af2d3f0 + 484b304 commit 15e57b8

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/ci/docker/dist-x86_64-linux/build-gcc.sh

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ hide_output ../gcc-$GCC/configure \
3232
--enable-languages=c,c++
3333
hide_output make -j10
3434
hide_output make install
35+
ln -s gcc /rustroot/bin/cc
3536

3637
cd ..
3738
rm -rf gcc-build

0 commit comments

Comments
 (0)