Skip to content

Commit 08a4a47

Browse files
authored
Revert "Go back to CMake 3.25.2 (pybind#4496)" (pybind#4503)
* Revert "Go back to CMake 3.25.2 (pybind#4496)" This reverts commit b8f2855. * Apply patch provided by @bradking (with pre-commit cmake-format auto fixes). pybind#4503 (comment)
1 parent 535f81a commit 08a4a47

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

.github/workflows/ci.yml

-6
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,6 @@ jobs:
8383

8484
- name: Update CMake
8585
uses: jwlawson/[email protected]
86-
# TEMPORARILY pin version because 3.26.0-rc1 is failing under macOS:
87-
with:
88-
cmake-version: '3.25.2'
8986

9087
- name: Cache wheels
9188
if: runner.os == 'macOS'
@@ -1074,9 +1071,6 @@ jobs:
10741071

10751072
- name: Update CMake
10761073
uses: jwlawson/[email protected]
1077-
# TEMPORARILY pin version because 3.26.0-rc1 is failing under macOS:
1078-
with:
1079-
cmake-version: '3.25.2'
10801074

10811075
- name: Run pip installs
10821076
run: |

tools/FindCatch.cmake

+6-2
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,14 @@ endfunction()
3636
function(_download_catch version destination_dir)
3737
message(STATUS "Downloading catch v${version}...")
3838
set(url https://github.com/philsquared/Catch/releases/download/v${version}/catch.hpp)
39-
file(DOWNLOAD ${url} "${destination_dir}/catch.hpp" STATUS status)
39+
file(
40+
DOWNLOAD ${url} "${destination_dir}/catch.hpp"
41+
STATUS status
42+
LOG log)
4043
list(GET status 0 error)
4144
if(error)
42-
message(FATAL_ERROR "Could not download ${url}")
45+
string(REPLACE "\n" "\n " log " ${log}")
46+
message(FATAL_ERROR "Could not download URL:\n" " ${url}\n" "Log:\n" "${log}")
4347
endif()
4448
set(CATCH_INCLUDE_DIR
4549
"${destination_dir}"

0 commit comments

Comments
 (0)