Skip to content

Commit a1db516

Browse files
committed
fix: moved the of loop that adds dataOriginal to inside if elements
1 parent 34ba31a commit a1db516

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

demo/render.array.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ <h4>{{domains}}</h4>
1919
</cc-options>
2020

2121
<div class="template" template_id="abc1">
22-
<div class="template" render-array="data.current" render-key="current_org" value="{{current_org.name}}">
22+
<div class="template" render-array="data[0].current" render-key="current_org" value="{{current_org.name}}">
2323
<h3>{{current_org.name}}</h3>
2424
</div>
2525
</div>

demo/render.object.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ <h1> {{data.collection}} {{data._id}}</h1> -->
1616
<div class="template" render-object="" render-key="one">
1717
<h5>{{one.key}}: {{one.value}}</h5>
1818
</div>
19-
<div class="template" render-array="data.current_org" render-key="current_org" value="{{current_org}}">
19+
<div class="template" render-array="data[0].current_org" render-key="current_org" value="{{current_org}}">
2020
<h3>{{current_org}}</h3>
2121
</div>
2222
</div>

src/index.js

+10-4
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,13 @@ const CoCreateRender = {
263263
}
264264
if (el.classList.contains('template') && !el.hasAttribute('template_id')) {
265265
that.render(el, data);
266-
}
266+
}
267+
// if (el.hasAttribute('render-array') || el.hasAttribute('render-object')) {
268+
// if (!el.dataOriginal) {
269+
// that.render(el, data);
270+
// }
271+
// }
272+
267273
}
268274

269275
if (el.nodeType == 3) {
@@ -325,9 +331,6 @@ const CoCreateRender = {
325331
this.dataOriginal = {...data};
326332
delete this.dataOriginal.data
327333

328-
for (let element of elements)
329-
element.dataOriginal = {...this.dataOriginal};
330-
331334
if (selector) {
332335
let template = queryDocumentSelector(selector);
333336
if (!template) return;
@@ -338,6 +341,9 @@ const CoCreateRender = {
338341
else
339342
this.setValue([template], data);
340343
} else if (elements) {
344+
for (let element of elements)
345+
element.dataOriginal = {...this.dataOriginal};
346+
341347
if (elements.length == 1 && elements[0].classList.contains('template')){
342348
this.render(elements[0], data);
343349
}

0 commit comments

Comments
 (0)