Skip to content

Commit 651ceb0

Browse files
committed
Handle invalid attributes and log all failed captures in debug
1 parent 24866c1 commit 651ceb0

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

bin/quickscrape.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ if (program.scraperdir) {
118118
}
119119
if (program.scraper) {
120120
var definition = fs.readFileSync(program.scraper);
121-
var scraper = new Scraper(definition);
121+
var scraper = new Scraper(JSON.parse(definition));
122122
if (!scraper.valid) {
123123
scraper.on('definitionError', function(problems) {
124124
log.error('the scraper provided was not valid for the following reason(s):');

lib/eventparse.js

+6
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ var mapping = {
3232
[scraper, 'element capture failed'],
3333
'scraper.elementResults':
3434
[scraper, 'element results'],
35+
'scraper.selectorFailed':
36+
[scraper, 'selector had no results'],
37+
'scraper.attributeFailed':
38+
[scraper, 'attribute was not valid'],
3539
'scrapersLoaded':
3640
[scraperBox, 'scrapers loaded'],
3741
'gettingScraper':
@@ -53,6 +57,8 @@ module.exports.getlevel = function(event) {
5357
return 'data';
5458
} else if (/elementResults/.test(event)) {
5559
return 'debug';
60+
} else if (/Failed/.test(event)) {
61+
return 'debug';
5662
}
5763
return 'info';
5864
}

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"chalk": "~1.0.0",
3535
"commander": "~2.7.1",
3636
"moment": "~2.10.2",
37-
"thresher": "^0.1.8",
37+
"thresher": "^0.1.9",
3838
"which": "~1.0.5",
3939
"winston": "~1.0.0"
4040
},

0 commit comments

Comments
 (0)