Skip to content

Commit 2a5755a

Browse files
committed
Set resource name
1 parent cd21985 commit 2a5755a

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

contrib/envoyproxy/go-control-plane/envoy.go

+2
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"io"
1212
"math"
1313
"net/http"
14+
"path"
1415
"strings"
1516

1617
"gopkg.in/DataDog/dd-trace-go.v1/contrib/internal/httptrace"
@@ -204,6 +205,7 @@ func processRequestHeaders(ctx context.Context, req *envoyextproc.ProcessingRequ
204205
var blocked bool
205206
fakeResponseWriter := newFakeResponseWriter()
206207
wrappedResponseWriter, request, afterHandle, blocked := httptrace.BeforeHandle(&httptrace.ServeConfig{
208+
Resource: request.Method + " " + path.Clean(request.URL.Path),
207209
SpanOpts: []ddtrace.StartSpanOption{
208210
tracer.Tag(ext.SpanKind, ext.SpanKindServer),
209211
tracer.Tag(ext.Component, componentName),

contrib/envoyproxy/go-control-plane/envoy_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ func TestGeneratedSpan(t *testing.T) {
254254
stream, err := client.Process(ctx)
255255
require.NoError(t, err)
256256

257-
end2EndStreamRequest(t, stream, "/resource-span", "GET", map[string]string{"user-agent": "Mistake Not...", "test-key": "test-value"}, map[string]string{"response-test-key": "response-test-value"}, false)
257+
end2EndStreamRequest(t, stream, "/../../../resource-span/.?id=test", "GET", map[string]string{"user-agent": "Mistake Not...", "test-key": "test-value"}, map[string]string{"response-test-key": "response-test-value"}, false)
258258

259259
err = stream.CloseSend()
260260
require.NoError(t, err)
@@ -266,10 +266,10 @@ func TestGeneratedSpan(t *testing.T) {
266266
// Check for tags
267267
span := finished[0]
268268
require.Equal(t, "http.request", span.OperationName())
269-
require.Equal(t, "https://datadoghq.com/resource-span", span.Tag("http.url"))
269+
require.Equal(t, "https://datadoghq.com/../../../resource-span/.?id=test", span.Tag("http.url"))
270270
require.Equal(t, "GET", span.Tag("http.method"))
271271
require.Equal(t, "datadoghq.com", span.Tag("http.host"))
272-
// require.Equal(t, "GET /resource-span", span.Tag("resource.name"))
272+
require.Equal(t, "GET /resource-span", span.Tag("resource.name"))
273273
require.Equal(t, "server", span.Tag("span.kind"))
274274
require.Equal(t, "Mistake Not...", span.Tag("http.useragent"))
275275
})

0 commit comments

Comments
 (0)