fix: allow custom attrs for external links

Author: Alexander Lichter

lib/index.js

@@ -46,8 +46,8 @@ const vueLinkFactory = slashes => ({
 
     return isLinkedToExternal
       ? h('a', {
-        ...data,
         attrs: {
+          ...data.attrs,
           href: data.props.to || undefined,
           rel: data.props.rel || 'noopener',
           target: data.props.target || (data.props.newTab ? '_blank' : undefined)

test/VueLink.spec.js

@@ -37,6 +37,32 @@ describe('VueLink', () => {
 
       expect(link.vm.$props.to).toBe('/test')
     })
+    it('does apply custom props', () => {
+      const wrapper = mount(VueLink, {
+        localVue,
+        attachToDocument: true,
+        stubs: {
+          RouterLink: RouterLinkStub
+        },
+        context: {
+          props: {
+            to: '/test',
+            title: 'ABC'
+          }
+        },
+        slots: {
+          default: '<div>Hi</div>'
+        }
+      })
+
+      expect(wrapper.isVueInstance()).toBe(true)
+      expect(wrapper.contains(RouterLinkStub)).toBe(true)
+
+      const link = wrapper.find(RouterLinkStub)
+
+      expect(link.vm.$props.to).toBe('/test')
+      expect(wrapper.html()).toMatchSnapshot()
+    })
   })
   describe('external', () => {
     it('does trigger external on http link', () => {
@@ -212,6 +238,28 @@ describe('VueLink', () => {
       expect(wrapper.isVueInstance()).toBe(false)
       expect(wrapper.contains(RouterLinkStub)).toBe(false)
 
+      expect(wrapper.html()).toMatchSnapshot()
+    })
+    it('does bind custom prop', () => {
+      const wrapper = mount(VueLink, {
+        localVue,
+        attachToDocument: true,
+        stubs: {
+          RouterLink: RouterLinkStub
+        },
+        context: {
+          attrs: {
+            title: 'ABC'
+          }
+        },
+        slots: {
+          default: '<div>Hi</div>'
+        }
+      })
+
+      expect(wrapper.isVueInstance()).toBe(false)
+      expect(wrapper.contains(RouterLinkStub)).toBe(false)
+
       expect(wrapper.html()).toMatchSnapshot()
     })
   })

test/__snapshots__/VueLink.spec.js.snap

@@ -1,5 +1,11 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`VueLink external does bind custom prop 1`] = `
+<a title="ABC" rel="noopener">
+  <div>Hi</div>
+</a>
+`;
+
 exports[`VueLink external does not bind href if unset 1`] = `
 <a rel="noopener">
   <div>Hi</div>
@@ -47,3 +53,9 @@ exports[`VueLink external does trigger external on https link 1`] = `
   <div>Hi</div>
 </a>
 `;
+
+exports[`VueLink router-link does apply custom props 1`] = `
+<a>
+  <div>Hi</div>
+</a>
+`;