Skip to content

Commit efbb1a6

Browse files
committed
[FIX] makefile: fix overridden css
The previous makefile was compiling css beside the style.scss and the style.css was copied at the end. The new makefile compile css directly in the build dir. Since this file was still present in the source because of the .gitignore, sphinx was using this old version of style.css, overriding the new compiled css file at the end. Removing it from gitignore should helpFix this problem. This commit also fix some path in makefile. (not critical but this should fix a potential error in static command) closes odoo#1089 X-original-commit: fd56d8c Signed-off-by: Antoine Vandevenne (anv) <[email protected]> Signed-off-by: Xavier Dollé (xdo) <[email protected]>
1 parent f0550c3 commit efbb1a6

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
# Sphinx build files
66
_build/
7-
extensions/odoo_theme/static/style.css
87

98
# Dependencies
109
odoo

Makefile

+4-4
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ clean:
4242
rm -rf $(BUILD_DIR)/*
4343
@echo "Cleaning finished."
4444

45-
html: $(HTML_BUILD_DIR)/html/_static/style.css
45+
html: $(HTML_BUILD_DIR)/_static/style.css
4646
@echo "Starting build..."
4747
$(SPHINX_BUILD) -c $(CONFIG_DIR) -b html $(SPHINXOPTS) $(SOURCE_DIR) $(HTML_BUILD_DIR)
4848
@echo "Build finished."
@@ -62,7 +62,7 @@ gettext:
6262
$(SPHINX_BUILD) -c $(CONFIG_DIR) -b gettext $(SOURCE_DIR) locale/sources
6363
@echo "Generation finished."
6464

65-
$(HTML_BUILD_DIR)/html/_static/style.css: extensions/odoo_theme/static/style.scss extensions/odoo_theme/static/scss/*.scss
65+
$(HTML_BUILD_DIR)/_static/style.css: extensions/odoo_theme/static/style.scss extensions/odoo_theme/static/scss/*.scss
6666
@echo "Compiling stylesheets..."
6767
mkdir -p $(HTML_BUILD_DIR)/_static
6868
pysassc extensions/odoo_theme/static/style.scss $(HTML_BUILD_DIR)/_static/style.css
@@ -74,5 +74,5 @@ fast: SPHINXOPTS += -A collapse_menu=True
7474
fast: html
7575

7676
static: $(HTML_BUILD_DIR)/static/style.css
77-
cp -r extensions/odoo_theme/static/* $(HTML_BUILD_DIR)/html/_static/
78-
cp -r static/* $(HTML_BUILD_DIR)/html/_static/
77+
cp -r extensions/odoo_theme/static/* $(HTML_BUILD_DIR)/_static/
78+
cp -r static/* $(HTML_BUILD_DIR)/_static/

0 commit comments

Comments
 (0)