Skip to content

C++ string formatting is leaking memory #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sylveon opened this issue May 22, 2021 · 0 comments
Open

C++ string formatting is leaking memory #28

sylveon opened this issue May 22, 2021 · 0 comments

Comments

@sylveon
Copy link

sylveon commented May 22, 2021

ReswPlus/src/VSExtension/ReswPlus.Core/CodeGenerators/CppCXCodeGenerator.cs

Line 257 in f44b81c

builderCpp.AppendLine($"wchar_t *buffer = new wchar_t[needed + 1];");

ReswPlus/src/VSExtension/ReswPlus.Core/CodeGenerators/CppWinRTCodeGenerator.cs

Line 274 in f44b81c

builderCpp.AppendLine($"wchar_t *buffer = new wchar_t[needed + 1];");

These two buffers are allocated, but never freed, leading to a memory leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed memory leak in C++ string formatting JUV-Studios/ReswPlus
1 participant
@sylveon