Skip to content

Commit f9f2b66

Browse files
authored
Rollup merge of rust-lang#69637 - matthiaskrgr:if_let_some_result, r=ecstatic-morse
Don't convert Results to Options just for matching.
2 parents 68885ab + 0ec1408 commit f9f2b66

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/librustc_resolve/imports.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1252,7 +1252,7 @@ impl<'a, 'b> ImportResolver<'a, 'b> {
12521252
// this may resolve to either a value or a type, but for documentation
12531253
// purposes it's good enough to just favor one over the other.
12541254
self.r.per_ns(|this, ns| {
1255-
if let Some(binding) = source_bindings[ns].get().ok() {
1255+
if let Ok(binding) = source_bindings[ns].get() {
12561256
this.import_res_map.entry(directive.id).or_default()[ns] = Some(binding.res());
12571257
}
12581258
});
@@ -1293,7 +1293,7 @@ impl<'a, 'b> ImportResolver<'a, 'b> {
12931293
let mut redundant_span = PerNS { value_ns: None, type_ns: None, macro_ns: None };
12941294

12951295
self.r.per_ns(|this, ns| {
1296-
if let Some(binding) = source_bindings[ns].get().ok() {
1296+
if let Ok(binding) = source_bindings[ns].get() {
12971297
if binding.res() == Res::Err {
12981298
return;
12991299
}

src/libstd/net/addr.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -901,7 +901,7 @@ impl ToSocketAddrs for str {
901901
type Iter = vec::IntoIter<SocketAddr>;
902902
fn to_socket_addrs(&self) -> io::Result<vec::IntoIter<SocketAddr>> {
903903
// try to parse as a regular SocketAddr first
904-
if let Some(addr) = self.parse().ok() {
904+
if let Ok(addr) = self.parse() {
905905
return Ok(vec![addr].into_iter());
906906
}
907907

0 commit comments

Comments
 (0)