Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inara plugin to use incremental shiplocker updates when sending info (and send backpack, if possible on INARAs side) #1162

Open
A-UNDERSCORE-D opened this issue Jun 10, 2021 · 1 comment

Comments

@A-UNDERSCORE-D
Copy link
Contributor

A-UNDERSCORE-D commented Jun 10, 2021

Currently we:
1. Only send ship locker info, backpacks arent included
2. Only send FULL ship locker info, transfers are not included

For 1, we're waiting on a response from artie about if we should, if so...
1. We need to track what we've sent to artie and remove stuff from the backpack if the player dies (or assume the next ShipLocker will get it
2. implement additional backpack endpoints if those become a thing

Update from artie, dont do this until some time in the future if backpack specific support is added

for 2, if transfers are working correctly we should send them to incrementally update inara

@A-UNDERSCORE-D A-UNDERSCORE-D changed the title Update inara plugin to use incremental backpack updates when sending info Update inara plugin to use incremental shiplocker updates when sending info (and send backpack, if possible on INARAs side) Jun 10, 2021
@Athanasius
Copy link
Contributor

Artie said:

[14:19] Artie : yeah, better to keep it shiplocker-only for now. Less problem for everybody :slight_smile:
[14:20] Artie : in the Inara API events, everything is presumed to be in a shiplocker and it may be extended for the backpack in the future (by allowing another value in the itemLocation property)

@Rixxan Rixxan added this to the Post-6.0 Changes milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants