Enable switching from New to Old Dot on web when copiloted in

[dangrous]

Problem

Currently we disabled switching to/from new/old dot when logged in as a copilot, since the functionality wasn't enabled. It is now!

Why is this important?

Allows full functionality for our users

Solution

Remove the blocks for both flows.

Discussed in Slack, but we are sending a new URL param, delegatorEmail, to the /transition route if the user needs to be re-logged in as a delegate once logged into the base account. We need to pick that up and call Delegate.connect with that info, and, once that's complete, land the user in the correct location.

Test cases:

• Copilot into an account in Old Dot - go to New Dot - return to Old Dot - switch back to original account
• Copilot into an account in New Dot - go to Old Dot - return to New Dot - switch back to original account
• Copilot into an account in Old Dot - go to New Dot - switch back to original account - return to Old Dot
• Copilot into an account in New Dot - go to Old Dot - switch back to original account - return to New Dot

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Enable switching from New to Old Dot on web when copiloted in

What is the root cause of that problem?

Currently we disabled switching to/from new/old dot when logged in as a copilot, since the functionality wasn't enabled

What changes do you think we should make in order to solve the problem?

1. Remove this code block:
   

   App/src/pages/settings/InitialSettingsPage.tsx

   Lines 263 to 266 in 3ffa779

   	if (isActingAsDelegate) {
   	setIsNoDelegateAccessMenuVisible(true);
   	return;
   	}

2. Remove these block components:

App/src/pages/settings/ExitSurvey/ExitSurveyConfirmPage.tsx

Line 64 in 3ffa779

<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>

App/src/pages/settings/ExitSurvey/ExitSurveyBookCall.tsx

Line 26 in 3ffa779

<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>

App/src/pages/settings/ExitSurvey/ExitSurveyReasonPage.tsx

Line 52 in 3ffa779

<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>

App/src/pages/settings/ExitSurvey/ExitSurveyResponsePage.tsx

Line 90 in 3ffa779

<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Don't need a test

What alternative solutions did you explore? (Optional)

[ZhenjaHorbach]

@thelullabyy
Thanks for your proposal
But sorry
This is not Help Wanted issue and I'm already working on it
And as part of this issue, we need to update the switch logic from OD to ND while preserving the active copilot if necessary

[thelullabyy]

@ZhenjaHorbach Thanks for your information!

[ZhenjaHorbach]

Not overdue
the PR is in progress