You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- if [ "$TWBS_TEST" = validate-html ]; then echo "ruby=$(basename $GEMDIR) jekyll=$JEKYLL_VERSION rouge=$ROUGE_VERSION" > pseudo_Gemfile.lock; fi
9
+
# Remove ./node_modules/.bin from PATH so node-which doesn't replace Unix which and cause RVM to barf. See https://github.com/travis-ci/travis-ci/issues/5092
10
+
- export PATH=$(python -c 'from sys import argv;from collections import OrderedDict as od;print(":".join(od((p,None) for p in argv[1].split(":") if p.startswith("/")).keys()))' "$PATH")
Bootstrap uses [GitHub's Releases feature](https://github.com/blog/1547-release-your-software) for its changelogs.
2
+
3
+
See [the Releases section of our GitHub project](https://github.com/twbs/bootstrap/releases) for changelogs for each release version of Bootstrap.
4
+
5
+
Release announcement posts on [the official Bootstrap blog](http://blog.getbootstrap.com) contain summaries of the most noteworthy changes made in each release.
Copy file name to clipboardexpand all lines: CONTRIBUTING.md
+31-9
Original file line number
Diff line number
Diff line change
@@ -18,24 +18,31 @@ the preferred channel for [bug reports](#bug-reports), [features requests](#feat
18
18
and [submitting pull requests](#pull-requests), but please respect the following
19
19
restrictions:
20
20
21
-
* Please **do not** use the issue tracker for personal support requests. Stack
22
-
Overflow ([`twitter-bootstrap-3`](http://stackoverflow.com/questions/tagged/twitter-bootstrap-3) tag) or [IRC](README.md#community) are better places to get help.
21
+
* Please **do not** use the issue tracker for personal support requests. Stack
22
+
Overflow ([`twitter-bootstrap-3`](https://stackoverflow.com/questions/tagged/twitter-bootstrap-3) tag), [Slack](https://bootstrap-slack.herokuapp.com/) or [IRC](README.md#community) are better places to get help.
23
23
24
24
* Please **do not** derail or troll issues. Keep the discussion on topic and
25
25
respect the opinions of others.
26
26
27
+
* Please **do not** post comments consisting solely of "+1" or ":thumbsup:".
28
+
Use [GitHub's "reactions" feature](https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments)
29
+
instead. We reserve the right to delete comments which violate this rule.
30
+
27
31
* Please **do not** open issues or pull requests regarding the code in
28
32
[`Normalize`](https://github.com/necolas/normalize.css) (open them in
29
33
their respective repositories).
30
34
35
+
* Please **do not** open issues regarding the official themes offered on <http://themes.getbootstrap.com/>.
36
+
Instead, please email any questions or feedback regarding those themes to `themes AT getbootstrap DOT com`.
37
+
31
38
32
39
## Issues and labels
33
40
34
41
Our bug tracker utilizes several labels to help organize and identify issues. Here's what they represent and how we use them:
35
42
36
43
-`browser bug` - Issues that are reported to us, but actually are the result of a browser-specific bug. These are diagnosed with reduced test cases and result in an issue opened on that browser's own bug tracker.
37
44
-`confirmed` - Issues that have been confirmed with a reduced test case and identify a bug in Bootstrap.
38
-
-`css` - Issues stemming from our compiled CSS or source Less files.
45
+
-`css` - Issues stemming from our compiled CSS or source Less/Sass files.
39
46
-`customizer` - Issues with our web-based Customizer.
40
47
-`docs` - Issues for improving or updating our documentation.
41
48
-`examples` - Issues involving the example templates included in our docs.
@@ -66,7 +73,7 @@ Guidelines for bug reports:
66
73
latest `master` or development branch in the repository.
67
74
68
75
3.**Isolate the problem**— ideally create a [reduced test
69
-
case](http://css-tricks.com/6263-reduced-test-cases/) and a live example.
76
+
case](https://css-tricks.com/reduced-test-cases/) and a live example.
70
77
[This JS Bin](http://jsbin.com/lefey/1/edit?html,output) is a helpful template.
71
78
72
79
@@ -105,7 +112,7 @@ When feasible, we aim to report such upstream bugs to the relevant browser vendo
105
112
| Mozilla | Firefox | Gecko |https://bugzilla.mozilla.org/enter_bug.cgi| "Core" is normally the right product option to choose. |
106
113
| Apple | Safari | WebKit |https://bugs.webkit.org/enter_bug.cgi?product=WebKit <br> https://bugreport.apple.com| In Apple's bug reporter, choose "Safari" as the product. |
107
114
| Google, Opera | Chrome, Chromium, Opera v15+ | Blink |https://code.google.com/p/chromium/issues/list| Click the "New issue" button. |
108
-
| Microsoft |Internet Explorer| Trident|https://connect.microsoft.com/IE/feedback/LoadSubmitFeedbackForm||
115
+
| Microsoft |Edge | EdgeHTML |https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/||
109
116
110
117
### Issues bots
111
118
@@ -114,7 +121,13 @@ When feasible, we aim to report such upstream bugs to the relevant browser vendo
114
121
115
122
## Feature requests
116
123
117
-
Feature requests are welcome. But take a moment to find out whether your idea
124
+
Feature requests are welcome, but please note that they **must target
125
+
[Bootstrap v4](https://github.com/twbs/bootstrap/tree/v4-dev),** because
126
+
Bootstrap v3 is now in maintenance mode and is closed off to new features.
127
+
This is so that we can focus our efforts on Bootstrap v4, the future of the
128
+
framework.
129
+
130
+
Before opening a feature request, please take a moment to find out whether your idea
118
131
fits with the scope and aims of the project. It's up to *you* to make a strong
119
132
case to convince the project's developers of the merits of this feature. Please
120
133
provide as much detail and context as possible.
@@ -131,13 +144,21 @@ implementing features, refactoring code, porting to a different language),
131
144
otherwise you risk spending a lot of time working on something that the
132
145
project's developers might not want to merge into the project.
133
146
147
+
In particular, **pull requests that add new features to Bootstrap v3 will be
148
+
rejected.** Bootstrap v3 is now in maintenance mode and is therefore closed
149
+
off to new features, so that we can focus our efforts on Bootstrap v4, the
150
+
future of the framework. Pull requests that add new features should target
151
+
[Bootstrap v4 (the `v4-dev` git branch)](https://github.com/twbs/bootstrap/tree/v4-dev)
152
+
instead, where they will be welcomed and duly considered.
153
+
134
154
Please adhere to the [coding guidelines](#code-guidelines) used throughout the
135
155
project (indentation, accurate comments, etc.) and any other requirements
136
156
(such as test coverage).
137
157
138
158
**Do not edit `bootstrap.css`, `bootstrap-theme.css`, or `bootstrap.js`
139
159
directly!** Those files are automatically generated. You should edit the
140
-
source files in [`/bootstrap/less/`](https://github.com/twbs/bootstrap/tree/master/less)
160
+
source files in [`/bootstrap/less/`](https://github.com/twbs/bootstrap/tree/master/less),
feature to tidy up your commits before making them public.
183
204
@@ -235,6 +256,7 @@ includes code changes) and under the terms of the
235
256
- 2 spaces (no tabs)
236
257
- strict mode
237
258
- "Attractive"
259
+
- Don't use [jQuery event alias convenience methods](https://github.com/jquery/jquery/blob/master/src/event/alias.js) (such as `$().focus()`). Instead, use [`$().trigger(eventType, ...)`](http://api.jquery.com/trigger/) or [`$().on(eventType, ...)`](http://api.jquery.com/on/), depending on whether you're firing an event or listening for an event. (For example, `$().trigger('focus')` or `$().on('focus', function (event) { /* handle focus event */ })`) We do this to be compatible with custom builds of jQuery where the event aliases module has been excluded.
0 commit comments