Skip to content

Commit 39ce694

Browse files
authored
Merge pull request dsaltares#40 from umireon/release-id
Respect release_id
2 parents 09d3d48 + 71be130 commit 39ce694

File tree

3 files changed

+38
-2
lines changed

3 files changed

+38
-2
lines changed

.github/workflows/demo.yml

+36
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,40 @@ jobs:
4242
- name: Display the file (Windows)
4343
run: dir subdir/plague-linux.zip
4444
if: matrix.runs-on == 'windows-latest'
45+
46+
release_id:
47+
strategy:
48+
matrix:
49+
runs-on:
50+
- ubuntu-latest
51+
- macos-latest
52+
- windows-latest
53+
54+
name: Release ID
55+
runs-on: ${{ matrix.runs-on }}
56+
steps:
57+
- name: Checkout
58+
uses: actions/checkout@v2
59+
- name: Create a subdirectory
60+
run: |
61+
mkdir subdir
62+
- name: Get the latest release
63+
id: get_release
64+
uses: ./
65+
with:
66+
repo: "dsaltares/godot-wild-jam-18"
67+
version: "23960137"
68+
file: "plague-linux.zip"
69+
target: "subdir/plague-linux.zip"
70+
- name: Display the outputs
71+
run: |
72+
echo "${{ steps.get_release.outputs.version }}"
73+
echo "${{ steps.get_release.outputs.name }}"
74+
echo "${{ steps.get_release.outputs.body }}"
75+
- name: Display the file (Linux, Mac)
76+
run: ls -l subdir/plague-linux.zip
77+
if: matrix.runs-on != 'windows-latest'
78+
- name: Display the file (Windows)
79+
run: dir subdir/plague-linux.zip
80+
if: matrix.runs-on == 'windows-latest'
4581

dist/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -12110,7 +12110,7 @@ var getRelease = (octokit, { owner, repo, version }) => {
1211012110
} else if (tagsMatch !== null && tagsMatch[1]) {
1211112111
return octokit.rest.repos.getReleaseByTag({ owner, repo, tag: tagsMatch[1] });
1211212112
} else {
12113-
throw new Error("Malformed version");
12113+
return octokit.rest.repos.getRelease({ owner, repo, release_id: Math.trunc(Number(version)) });
1211412114
}
1211512115
};
1211612116
var MAX_RETRY = 5;

index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const getRelease = (octokit: ReturnType<typeof github.getOctokit>, { owner, repo
3636
} else if (tagsMatch !== null && tagsMatch[1]) {
3737
return octokit.rest.repos.getReleaseByTag({ owner, repo, tag: tagsMatch[1] })
3838
} else {
39-
throw new Error('Malformed version')
39+
return octokit.rest.repos.getRelease({ owner, repo, release_id: Math.trunc(Number(version)) })
4040
}
4141
}
4242

0 commit comments

Comments
 (0)