Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading d3-scale to v2.4 is causing error in IE #1595

Closed
vinojv opened this issue May 31, 2020 · 4 comments
Closed

upgrading d3-scale to v2.4 is causing error in IE #1595

vinojv opened this issue May 31, 2020 · 4 comments

Comments

@vinojv
Copy link

vinojv commented May 31, 2020

"d3-array": "^2.4.0",

upgrading d3-scale to v2.4 is causing an error in IE in the following code
SCRIPT1004: Expected ';'

/***/ "./node_modules/d3-array/src/count.js":

"use strict";
__webpack_require__.r(__webpack_exports__);
/* harmony export (binding) */ __webpack_require__.d(__webpack_exports__, "default", function() { return count; });
function count(values, valueof) {
  let count = 0;
  if (valueof === undefined) {
->    for (let value of values) {
      if (value != null && (value = +value) >= value) {
        ++count;
      }
    }
@Harim-T
Copy link

Harim-T commented Jun 10, 2020

Having the same issue.

@Fil
Copy link

Fil commented Jun 11, 2020

you mean d3-array@2

please see https://github.com/d3/d3-array/releases/tag/v2.0.0

@pancr9
Copy link

pancr9 commented Jun 10, 2021

Seeing same issue.

@becca-bailey
Copy link
Contributor

We have had some issues with upgrading our d3 packages. In the current version of Victory, d3-scale is pinned at ^1.00 to avoid this issue. This should be resolved for now, but I opened up another issue (#2124) to look into this dependency issue a little further before upgrading this package again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants