rubocop -a --only Style/DefWithParentheses

Author: Fryguy

Diff for: app/models/ext_management_system.rb

@@ -781,15 +781,15 @@ def vm_count_by_state(state)
     vms.inject(0) { |t, vm| vm.power_state == state ? t + 1 : t }
   end
 
-  def total_vms_on() = vm_count_by_state("on")
+  def total_vms_on = vm_count_by_state("on")
 
-  def total_vms_off() = vm_count_by_state("off")
+  def total_vms_off = vm_count_by_state("off")
 
-  def total_vms_unknown() = vm_count_by_state("unknown")
+  def total_vms_unknown = vm_count_by_state("unknown")
 
-  def total_vms_never() = vm_count_by_state("never")
+  def total_vms_never = vm_count_by_state("never")
 
-  def total_vms_suspended() = vm_count_by_state("suspended")
+  def total_vms_suspended = vm_count_by_state("suspended")
 
   def get_reserve(field)
     (hosts + ems_clusters).inject(0) { |v, obj| v + (obj.send(field) || 0) }

Diff for: app/models/miq_template.rb

@@ -37,7 +37,7 @@ def self.without_volume_templates
                         "ManageIQ::Providers::Openstack::CloudManager::VolumeSnapshotTemplate"])
   end
 
-  def active?() = false
+  def active? = false
 
   def self.display_name(number = 1)
     n_('Template and Image', 'Templates and Images', number)

Diff for: app/models/vim_performance_daily.rb

@@ -1,5 +1,5 @@
 class VimPerformanceDaily < MetricRollup
-  def self.instances_are_derived?() = true
+  def self.instances_are_derived? = true
 
   INFO_COLS = [:resource_type, :resource_id, :resource_name]
   PARENT_COLS = [:parent_host_id, :parent_ems_cluster_id, :parent_storage_id, :parent_ems_id].freeze

Diff for: lib/extensions/ar_miq_set.rb

@@ -97,7 +97,7 @@ module ClassMethods
     #       this class save the *_type column with the full sub-class's name as opposed to the
     #       base model class. This is needed so that tagging works properly. Once tagging is reworked
     #       to handle the base model class name this can be removed and real STI can be used.
-    def descends_from_active_record?() = false
+    def descends_from_active_record? = false
 
     def model_class
       @model_class ||= name[0..-4].constantize

Diff for: spec/factories/dialog.rb

@@ -9,7 +9,7 @@
     # skip validate_children callback for general dialog testing
     to_create do |instance|
       class << instance
-        def validate_children() = true
+        def validate_children = true
       end
       instance.save!
     end

Diff for: spec/factories/dialog_group.rb

@@ -9,7 +9,7 @@
     # skip validate_children callback for general dialog testing
     to_create do |instance|
       class << instance
-        def validate_children() = true
+        def validate_children = true
       end
       instance.save!
     end

Diff for: spec/factories/dialog_tab.rb

@@ -9,7 +9,7 @@
     # skip validate_children callback for general dialog testing
     to_create do |instance|
       class << instance
-        def validate_children() = true
+        def validate_children = true
       end
       instance.save!
     end

Diff for: spec/lib/extensions/ar_base_model_spec.rb

@@ -2,7 +2,7 @@
   context "with a test class" do
     let(:test_class) do
       Class.new(ActiveRecord::Base) do
-        def self.name() = "TestClass"
+        def self.name = "TestClass"
       end
     end
 
@@ -17,7 +17,7 @@ def self.name() = "TestClass"
     context "with a subclass" do
       let(:test_class_foo) do
         Class.new(test_class) do
-          def self.name() = "TestClassFoo"
+          def self.name = "TestClassFoo"
         end
       end
 

Diff for: spec/lib/extensions/ar_base_spec.rb

@@ -2,7 +2,7 @@
   context "with a test class" do
     let(:test_class) do
       Class.new(ActiveRecord::Base) do
-        def self.name() = "TestClass"
+        def self.name = "TestClass"
       end
     end
 

Diff for: spec/lib/uuid_mixin_spec.rb

@@ -1,7 +1,7 @@
 RSpec.describe UuidMixin do
   let(:test_class) do
     Class.new(ActiveRecord::Base) do
-      def self.name() = "TestClass"
+      def self.name = "TestClass"
       self.table_name = "service_templates"
       include UuidMixin
     end

Diff for: spec/models/mixins/ansible_playbook_mixin_spec.rb

@@ -1,7 +1,7 @@
 RSpec.describe AnsiblePlaybookMixin do
   let(:test_instance) do
     Class.new(ActiveRecord::Base) do
-      def self.name() = "TestClass"
+      def self.name = "TestClass"
       self.table_name = "services"
       include AnsiblePlaybookMixin
     end.new

Diff for: spec/models/mixins/authentication_mixin_spec.rb

@@ -9,7 +9,7 @@
 
   let(:test_class_instance) do
     Class.new(ActiveRecord::Base) do
-      def self.name() = "TestClass"
+      def self.name = "TestClass"
       self.table_name = "vms"
       include AuthenticationMixin
     end.new

Diff for: spec/models/mixins/custom_actions_mixin_spec.rb

@@ -1,7 +1,7 @@
 RSpec.describe CustomActionsMixin do
   let(:test_class) do
     Class.new(ActiveRecord::Base) do
-      def self.name() = "TestClass"
+      def self.name = "TestClass"
       self.table_name = "vms"
       include CustomActionsMixin
     end

Diff for: spec/models/mixins/custom_attribute_mixin_spec.rb

@@ -2,7 +2,7 @@
   let(:supported_factories) { [:vm_redhat, :host] }
   let(:test_class) do
     Class.new(ActiveRecord::Base) do
-      def self.name() = "TestClass"
+      def self.name = "TestClass"
       self.table_name = "vms"
       include CustomAttributeMixin
     end

Diff for: spec/models/mixins/external_url_spec.rb

@@ -1,7 +1,7 @@
 RSpec.describe ExternalUrlMixin do
   let(:test_class) do
     Class.new(ActiveRecord::Base) do
-      def self.name() = 'TestClass'
+      def self.name = 'TestClass'
       self.table_name = 'vms'
       include ExternalUrlMixin
     end