Skip to content

Commit 45f531b

Browse files
JaxLinAMDJaxLinAMD
committed
Update pal from commit: 3b17692
* Image corruption during memory defrag copy (Corrupt non power of 2 textures) * Fix random failure with XFBCaptureAndVerifyOnHost test cases when using vkDrawIndirectByteCountEXT() draw calls * Fix extra DccDecompress just before present if fullResolveDstOnly is set * Add a developer mode event service for forwarding events out the message bus in a lightweight way * Add a new type FmaskOnly for Image MetadataMode which makes color msaa Image only have Cmask/Fmask metadata * Avoid issue TCC metadata cache invalidation for image without metadata * Allow compressed copySrc layout for color msaa image that supports MetaDataTexFetch * Fix a minor logic error causing a whole bunch of extra updates to DCC state metadata inside PAL barriers * [GFX9/10] Remove need for RMW of CB_COLORx_INFO registers in most cases * Add PAL panel setting DisableSdmaEngine for debug purpose, the default value is false * Fix a bug of DCC constant encoding * Fix a memory corruption bug * Remove hardcoded timestampResetOnIdle value for Vega 20 * Fix a nullptr dereference due to an earlier OOM error. * Prevent the GPU profiler from turning every barrier's cache masks into garbage * Change CB_COLOR_INFO programming on Nested CmdBuf to be more like the old path * Mute the assertion for shaderWrite==0 for GFX9 when metadataMode is ForceEnabled * Fix excessive context rolls from waLqoHangWithRbPlus * [AcqRelBarrier] Optimizations on the use of WAIT_REG_MEM and WRITE_DATA packets * Work-around CTS 1.2 api.image_clearing.*.clear_depth_stencil_* random failures on Linux for asics before gfx10 * Don't do a fast compute depth clear outside of [0, 1] range, fixes dEQP-VK.pipeline.depth_range_unrestricted.*d32_sfloat_* by avoiding the compute path * Implement writing scaled copy regions in CmdBufferLogger * Notify tools of errors via Developer Callback * Add wave32 support for indirect command generator dispatches * Move graphics pipeline DB_RENDER_OVERRIDE RMW to the command buffer and add a DISABLE_VIEWPORT_CLAMP override * Disable DCC on mipmap array resource by default and adjust the UseDCC validation logic * Optimize Gfx10CreateUntypedBufferViewSrds to match GFX9 version * Mute assert to allow fixed 0 tileSwizzle value for non-single-sampled-color image * Fix ODR warnings from SDMA under GCC * Fix number of available VGPRs being reported * Percolate errors from Profiler up to the client * Fix PageFault in RenderDoc replay related to CB_COLOR_INFO dirty logic * Removal of Gfx10 specific builds of PAL * Bump version number to 248
1 parent 9fab160 commit 45f531b

File tree

250 files changed

+87464
-51687
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

250 files changed

+87464
-51687
lines changed

‎CMakeLists.txt

+3-11
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ option(PAL_BUILD_GPUOPEN "Build GPUOpen developer driver support?" OFF)
4040

4141
option(PAL_DBG_COMMAND_COMMENTS "Command with comments" OFF)
4242

43-
option(PAL_DEVELOPER_BUILD "Enable developer build" OFF)
44-
4543
option(PAL_ENABLE_PRINTS_ASSERTS "Enable print assertions?" ${CMAKE_BUILD_TYPE_DEBUG})
4644
cmake_dependent_option(PAL_MEMTRACK "Enable PAL memory tracker?" ${CMAKE_BUILD_TYPE_DEBUG} "PAL_ENABLE_PRINTS_ASSERTS" OFF)
4745

@@ -53,26 +51,22 @@ option(PAL_BUILD_DBG_OVERLAY "Build PAL Debug Overlay?" ON)
5351

5452
option(PAL_BUILD_GPU_PROFILER "Build PAL GPU Profiler?" ON)
5553

56-
option(PAL_BUILD_CMD_BUFFER_LOGGER "Build PAL Command Buffer Logger?" ${CMAKE_BUILD_TYPE_DEBUG})
57-
option(PAL_BUILD_INTERFACE_LOGGER "Build PAL Interface Logger?" ${CMAKE_BUILD_TYPE_DEBUG})
58-
option(PAL_BUILD_PM4_INSTRUMENTOR "Build PAL PM4 Instrumentor?" ${CMAKE_BUILD_TYPE_DEBUG})
59-
6054
option(PAL_BUILD_GFX "Build PAL with Graphics support?" ON)
6155
cmake_dependent_option(PAL_BUILD_GFX6 "Build PAL with GFX6 support?" ON "PAL_BUILD_GFX" OFF)
6256
cmake_dependent_option(PAL_BUILD_GFX9 "Build PAL with GFX9 support?" ON "PAL_BUILD_GFX" OFF)
6357
cmake_dependent_option(PAL_BUILD_VEGA20 "Build PAL with Vega20 support?" ON "PAL_BUILD_GFX" OFF)
6458
cmake_dependent_option(CHIP_HDR_VEGA20 "Build PAL chip with Vega20 support?" ON "PAL_BUILD_GFX" OFF)
59+
6560
cmake_dependent_option(PAL_BUILD_RAVEN2 "Build PAL with Raven2 support?" ON "PAL_BUILD_GFX" OFF)
6661
cmake_dependent_option(CHIP_HDR_RAVEN2 "Build PAL chip with Raven2 support?" ON "PAL_BUILD_GFX" OFF)
6762

68-
option(PAL_BUILD_GFX10 "Build PAL with GFX10 support?" OFF)
69-
7063
option(PAL_BUILD_OSS "Build PAL with Operating System support?" ON)
7164
cmake_dependent_option(PAL_BUILD_OSS1 "Build PAL with OSS1?" ON "PAL_BUILD_OSS" OFF)
7265
cmake_dependent_option(PAL_BUILD_OSS2 "Build PAL with OSS2?" ON "PAL_BUILD_OSS" OFF)
7366
cmake_dependent_option(PAL_BUILD_OSS2_4 "Build PAL with OSS2_4?" ON "PAL_BUILD_OSS" OFF)
7467
cmake_dependent_option(PAL_BUILD_OSS4 "Build PAL with OSS4?" ON "PAL_BUILD_OSS" OFF)
7568

69+
option(PAL_BUILD_DRI3 "Build PAL with DRI3 support?" ON)
7670
option(PAL_BUILD_WAYLAND "Build PAL with WAYLAND support?" OFF)
7771

7872
# PAL Client Options ###############################################################################
@@ -141,9 +135,7 @@ if(PAL_BUILD_GFX9)
141135
set(ADDR_RAVEN2_BUILD OFF CACHE BOOL "PAL override to build ADDRLIB with Vega20 support." FORCE)
142136
set(CHIP_HDR_RAVEN2 OFF CACHE BOOL "PAL override to build chip register header with Raven2 support." FORCE)
143137
endif()
144-
if(PAL_BUILD_GFX10)
145-
set(ADDR_GFX10_BUILD ON CACHE BOOL "PAL override to build ADDRLIB with GFX10 support." FORCE)
146-
endif()
138+
set(ADDR_GFX10_BUILD ON CACHE BOOL "PAL override to build ADDRLIB with GFX10 support." FORCE)
147139
if(PAL_BUILD_NAVI14)
148140
set(ADDR_NAVI14_BUILD ON CACHE BOOL "PAL override to build ADDRLIB with NAVI14 support." FORCE)
149141
endif()

‎cmake/Modules/AmdCmakeHelper.cmake

+25
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,28 @@
1+
##
2+
#######################################################################################################################
3+
#
4+
# Copyright (c) 2020 Advanced Micro Devices, Inc. All Rights Reserved.
5+
#
6+
# Permission is hereby granted, free of charge, to any person obtaining a copy
7+
# of this software and associated documentation files (the "Software"), to deal
8+
# in the Software without restriction, including without limitation the rights
9+
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10+
# copies of the Software, and to permit persons to whom the Software is
11+
# furnished to do so, subject to the following conditions:
12+
#
13+
# The above copyright notice and this permission notice shall be included in all
14+
# copies or substantial portions of the Software.
15+
#
16+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17+
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18+
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19+
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20+
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21+
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22+
# SOFTWARE.
23+
#
24+
#######################################################################################################################
25+
126
# Set up global CMake properties ###################################################################
227
cmake_minimum_required(VERSION 3.5)
328

‎cmake/Modules/FindDRM.cmake

+25
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,28 @@
1+
##
2+
#######################################################################################################################
3+
#
4+
# Copyright (c) 2020 Advanced Micro Devices, Inc. All Rights Reserved.
5+
#
6+
# Permission is hereby granted, free of charge, to any person obtaining a copy
7+
# of this software and associated documentation files (the "Software"), to deal
8+
# in the Software without restriction, including without limitation the rights
9+
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10+
# copies of the Software, and to permit persons to whom the Software is
11+
# furnished to do so, subject to the following conditions:
12+
#
13+
# The above copyright notice and this permission notice shall be included in all
14+
# copies or substantial portions of the Software.
15+
#
16+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17+
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18+
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19+
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20+
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21+
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22+
# SOFTWARE.
23+
#
24+
#######################################################################################################################
25+
126
set(_DRM_SEARCHES
227
/opt/amdgpu-pro/include
328
/opt/amdgpu-pro/include/libdrm

‎cmake/Modules/FindWayland.cmake

+25
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,28 @@
1+
##
2+
#######################################################################################################################
3+
#
4+
# Copyright (c) 2020 Advanced Micro Devices, Inc. All Rights Reserved.
5+
#
6+
# Permission is hereby granted, free of charge, to any person obtaining a copy
7+
# of this software and associated documentation files (the "Software"), to deal
8+
# in the Software without restriction, including without limitation the rights
9+
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10+
# copies of the Software, and to permit persons to whom the Software is
11+
# furnished to do so, subject to the following conditions:
12+
#
13+
# The above copyright notice and this permission notice shall be included in all
14+
# copies or substantial portions of the Software.
15+
#
16+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17+
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18+
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19+
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20+
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21+
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22+
# SOFTWARE.
23+
#
24+
#######################################################################################################################
25+
126
# Use pkg-config to get the directories
227
FIND_PACKAGE(PkgConfig)
328

‎cmake/Modules/FindXCB.cmake

+25
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,28 @@
1+
##
2+
#######################################################################################################################
3+
#
4+
# Copyright (c) 2020 Advanced Micro Devices, Inc. All Rights Reserved.
5+
#
6+
# Permission is hereby granted, free of charge, to any person obtaining a copy
7+
# of this software and associated documentation files (the "Software"), to deal
8+
# in the Software without restriction, including without limitation the rights
9+
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10+
# copies of the Software, and to permit persons to whom the Software is
11+
# furnished to do so, subject to the following conditions:
12+
#
13+
# The above copyright notice and this permission notice shall be included in all
14+
# copies or substantial portions of the Software.
15+
#
16+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17+
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18+
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19+
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20+
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21+
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22+
# SOFTWARE.
23+
#
24+
#######################################################################################################################
25+
126
set(_XCB_SEARCHES)
227

328
# Search XCB_ROOT first if it is set.

‎cmake/Modules/SetupAmdGlobalRoots.cmake

+25
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,28 @@
1+
##
2+
#######################################################################################################################
3+
#
4+
# Copyright (c) 2020 Advanced Micro Devices, Inc. All Rights Reserved.
5+
#
6+
# Permission is hereby granted, free of charge, to any person obtaining a copy
7+
# of this software and associated documentation files (the "Software"), to deal
8+
# in the Software without restriction, including without limitation the rights
9+
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10+
# copies of the Software, and to permit persons to whom the Software is
11+
# furnished to do so, subject to the following conditions:
12+
#
13+
# The above copyright notice and this permission notice shall be included in all
14+
# copies or substantial portions of the Software.
15+
#
16+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17+
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18+
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19+
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20+
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21+
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
22+
# SOFTWARE.
23+
#
24+
#######################################################################################################################
25+
126
#find_depth
227
if(NOT DEFINED GLOBAL_ROOT_SRC_DIR)
328
execute_process(

‎inc/core/pal.h

+11
Original file line numberDiff line numberDiff line change
@@ -643,6 +643,17 @@ struct PipelineHash
643643
uint64 unique; ///< Upper 64-bits of hash. "Unique" portion, suitable for e.g. pipeline cache use cases.
644644
};
645645

646+
/// Common shader pre and post compilation stats.
647+
struct CommonShaderStats
648+
{
649+
uint32 numUsedVgprs; ///< Number of VGPRs used by this shader
650+
uint32 numUsedSgprs; ///< Number of SGPRs used by this shader
651+
uint32 ldsSizePerThreadGroup; ///< LDS size per thread group in bytes.
652+
size_t ldsUsageSizeInBytes; ///< LDS usage by this shader.
653+
size_t scratchMemUsageInBytes; ///< Amount of scratch mem used by this shader.
654+
gpusize gpuVirtAddress; ///< Gpu mem address of shader ISA code.
655+
};
656+
646657
///@{
647658
/// Determines whether two ShaderHashes or PipelineHashes are equal.
648659
///

‎inc/core/palDeveloperHooks.h

+3-2
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,15 @@ struct BarrierOperations
154154
uint16 depthStencilExpand : 1; ///< Decompression of depth/stencil image.
155155
uint16 htileHiZRangeExpand : 1; ///< Expansion of HTile's HiZ range.
156156
uint16 depthStencilResummarize : 1; ///< Resummarization of depth stencil.
157-
uint16 dccDecompress : 1; ///< Dcc decompress BLT for color images.
157+
uint16 dccDecompress : 1; ///< DCC decompress BLT for color images.
158158
uint16 fmaskDecompress : 1; ///< Fmask decompression for shader readability.
159159
uint16 fastClearEliminate : 1; ///< Expand latest specified clear color into pixel data for the fast
160160
/// cleared color/depth resource.
161161
uint16 fmaskColorExpand : 1; ///< Completely decompresses the specified color resource.
162162
uint16 initMaskRam : 1; ///< Memsets uninitialized memory to prepare it for use as
163163
/// CMask/FMask/DCC/HTile.
164-
uint16 reserved : 8; ///< Reserved for future use.
164+
uint16 updateDccStateMetadata : 1; ///< DCC state metadata was updated.
165+
uint16 reserved : 7; ///< Reserved for future use.
165166
};
166167

167168
uint16 u16All; ///< Unsigned integer containing all the values.

‎inc/core/palDevice.h

+57-7
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,7 @@ class IPrivateScreen;
6464
class IQueryPool;
6565
class IQueue;
6666
class IQueueSemaphore;
67-
#if PAL_CLIENT_INTERFACE_MAJOR_VERSION >= 556
6867
class IShaderLibrary;
69-
#endif
7068
class ISwapChain;
7169
struct BorderColorPaletteCreateInfo;
7270
struct CmdAllocatorCreateInfo;
@@ -100,9 +98,7 @@ struct QueryPoolCreateInfo;
10098
struct QueueCreateInfo;
10199
struct QueueSemaphoreCreateInfo;
102100
struct QueueSemaphoreOpenInfo;
103-
#if PAL_CLIENT_INTERFACE_MAJOR_VERSION >= 556
104101
struct ShaderLibraryCreateInfo;
105-
#endif
106102
struct SwapChainCreateInfo;
107103
struct SwapChainProperties;
108104
struct SvmGpuMemoryCreateInfo;
@@ -275,6 +271,9 @@ enum class VcnIpLevel : uint32
275271
#endif
276272

277273
VcnIp1 = 0x1,
274+
#if PAL_BUILD_VCN3
275+
VcnIp3 = 0x4
276+
#endif
278277
};
279278

280279
/// Specifies which SPU IP level this device has.
@@ -866,7 +865,11 @@ struct DeviceProperties
866865
uint32 exclusive : 1; ///< Engine is exclusively owned by one client at a time.
867866
uint32 mustUseDispatchTunneling : 1; ///< Queues created on this engine must use dispatch
868867
/// tunneling.
869-
uint32 reserved : 30; ///< Reserved for future use.
868+
/// Indicates whether this engine instance can be used for gang submission workloads via
869+
/// a multi-queue.
870+
/// @see IDevice::CreateMultiQueue.
871+
uint32 supportsMultiQueue : 1;
872+
uint32 reserved : 29; ///< Reserved for future use.
870873
};
871874
uint32 u32All; ///< Flags packed as 32-bit uint.
872875
} flags; ///< Capabilities property flags.
@@ -875,6 +878,10 @@ struct DeviceProperties
875878
/// priority levels are supported by this engine.
876879
uint32 dispatchTunnelingPrioritySupport; ///< Mask of QueuePrioritySupport flags indicating which queue
877880
/// priority levels support dispatch tunneling on this engine.
881+
uint32 maxFrontEndPipes; ///< Up to this number of IQueue objects can be consumed in
882+
/// parallel by the front-end of this engine instance. It will
883+
/// only be greater than 1 on hardware scheduled engine backed
884+
/// by multiple hardware pipes/threads.
878885
} capabilities[MaxAvailableEngines]; ///< Lists each engine of this type (up to engineCount) and their
879886
/// properties.
880887

@@ -3048,6 +3055,51 @@ class IDevice
30483055
void* pPlacementAddr,
30493056
IQueue** ppQueue) = 0;
30503057

3058+
/// Determines the amount of system memory required for a multi-queue object. An allocation of this amount of
3059+
/// memory must be provided in the pPlacementAddr parameter of CreateMultiQueue().
3060+
///
3061+
/// @param [in] queueCount Number of queues in the gang; matches number of entries in pCreateInfo.
3062+
/// @param [in] pCreateInfo Properties of each queue to create for this gang (engine type, etc.). The first
3063+
/// entry in this array describes the master queue which will be used to execute all
3064+
/// IQueue interfaces except for MultiSubmit().
3065+
/// @param [out] pResult The validation result if pResult is non-null. This argument can be null to avoid the
3066+
/// additional validation.
3067+
///
3068+
/// @returns Size, in bytes, of system memory required for an multi-queue IQueue object with the specified
3069+
/// properties. A return value of 0 indicates the createInfo was invalid.
3070+
virtual size_t GetMultiQueueSize(
3071+
uint32 queueCount,
3072+
const QueueCreateInfo* pCreateInfo,
3073+
Result* pResult) const = 0;
3074+
3075+
/// Creates a multi-queue (i.e., gang submission queue) object. The resulting version of the IQueue interface
3076+
/// is composed of multiple hardware queues which can be atomically submitted to as a group. When this is done,
3077+
/// it is safe to use IGpuEvent objects to tightly synchronize work done across queues in a single call to Submit().
3078+
/// This can allow the client to tightly schedule asynchronous workloads for maximum efficiency that isn't possible
3079+
/// across queues using IQueueSemaphore objects.
3080+
///
3081+
/// @param [in] queueCount Number of queues in the gang; matches number of entries in the pCreateInfo array.
3082+
/// @param [in] pCreateInfo Properties of each queue to create for this gang (engine type, etc.). The first
3083+
/// entry in this array describes the master queue which will be used to execute all
3084+
/// IQueue interfaces except for the ganged-portion of a Submit() (e.g., Present()).
3085+
/// @param [in] pPlacementAddr Pointer to the location where PAL should construct this object. There must be as
3086+
/// much size available here as reported by calling GetMultiQueueSize() with the same
3087+
/// arguments.
3088+
/// @param [out] ppQueue Constructed multi queue object.
3089+
///
3090+
/// @returns Success if the multi queue was successfully created. Otherwise, one of the following errors may be
3091+
/// returned:
3092+
/// + ErrorInvalidValue if queueCount is less than 2.
3093+
/// + ErrorInvalidQueueType if any of the created sub-queues are not multi-queue compatible. This is
3094+
/// indicated by the supportsMultiQueue engineProperties flag in @ref DeviceProperties.
3095+
/// + ErrorInvalidPointer if pCreateInfo, pPlacementAddr or ppQueue is null.
3096+
/// + ErrorInvalidValue if any create info's configuration is invalid.
3097+
virtual Result CreateMultiQueue(
3098+
uint32 queueCount,
3099+
const QueueCreateInfo* pCreateInfo,
3100+
void* pPlacementAddr,
3101+
IQueue** ppQueue) = 0;
3102+
30513103
/// Determines the amount of system memory required for a GPU memory object.
30523104
///
30533105
/// An allocation of this amount of memory must be provided in the pPlacementAddr parameter of CreateGpuMemory().
@@ -3845,7 +3897,6 @@ class IDevice
38453897
void* pPlacementAddr,
38463898
IPipeline** ppPipeline) = 0;
38473899

3848-
#if PAL_CLIENT_INTERFACE_MAJOR_VERSION >= 556
38493900
/// Determines the amount of system memory required for a shader library object. An allocation of this amount of
38503901
/// memory must be provided in the pPlacementAddr parameter of CreateShaderLibrary().
38513902
///
@@ -3877,7 +3928,6 @@ class IDevice
38773928
const ShaderLibraryCreateInfo& createInfo,
38783929
void* pPlacementAddr,
38793930
IShaderLibrary** ppLibrary) = 0;
3880-
#endif
38813931

38823932
/// Determines the amount of system memory required for a graphics pipeline object. An allocation of this amount of
38833933
/// memory must be provided in the pPlacementAddr parameter of CreateGraphicsPipeline().

0 commit comments

Comments
 (0)