feat: imports API endpoints #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.98 kB (0%) Total Size: 285 kB
|
gumuz
changed the title
gumuz
changed the title
peterdeme
changed the title
ferhatelmas
reviewed
Jan 26, 2022
peterdeme
reviewed
Jan 27, 2022
src/client.ts
Outdated
| * @private | ||
| * @param {{ limit?: number; offset?: number }} options pagination options | ||
| * | ||
| * @return {APIResponse} An ImportTask |
There was a problem hiding this comment.
We should have a specific response type for this method and for the others as well, right?
Is import_task: {} accurate?
There was a problem hiding this comment.
this isn't exactly true since it's a richer version of it
maybe we should define listResponse, getResponse etc. How is it done in other endpoints?
peterdeme
reviewed
Jan 27, 2022
peterdeme
reviewed
Jan 27, 2022
peterdeme
reviewed
Jan 27, 2022
peterdeme
reviewed
Jan 27, 2022
Add types for Import API endpoints Update src/client.ts Update src/client.ts Update src/client.ts Update src/types.ts Co-Authored-By: Peter Deme <[email protected]>
peterdeme
approved these changes
Jan 28, 2022
|
lgtm |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Changelog