Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: thread reply preview not added to channel state #940

Merged
merged 4 commits into from
Apr 5, 2022

Conversation

szuperaz
Copy link
Contributor

@szuperaz szuperaz commented Apr 1, 2022

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

UI SDKs (for example Angular and React) create a message preview before sending a message request to the API and display those message previews in the message list while the message is being sent. There was a bug in the channel state where thread reply preview messages weren't added to the channel state. This was due to the recent jump to message functionality.

Changelog

  • fix: thread reply preview not added to channel state

@szuperaz szuperaz requested a review from petyosi April 1, 2022 07:37
@szuperaz szuperaz changed the title fix: Thread reply preview not added to channel state fix: thread reply preview not added to channel state Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Size Change: +350 B (0%)

Total Size: 299 kB

Filename Size Change
dist/browser.es.js 65.4 kB +88 B (0%)
dist/browser.full-bundle.min.js 35.7 kB -2 B (0%)
dist/browser.js 66.1 kB +87 B (0%)
dist/index.es.js 65.5 kB +93 B (0%)
dist/index.js 66.2 kB +84 B (0%)

compressed-size-action

@vishalnarkhede vishalnarkhede enabled auto-merge (squash) April 5, 2022 19:22
@vishalnarkhede vishalnarkhede merged commit 38d78af into master Apr 5, 2022
@vishalnarkhede vishalnarkhede deleted the fix-jump-to-message branch April 5, 2022 19:23
@github-actions github-actions bot mentioned this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants