Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): added support for thumb_url for video attachments in send file response #982

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Jun 3, 2022

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why, and How?

This PR adds the type of thumb_url for the response returned when a video file is uploaded to Stream CDN. The thumb_url is the URL of the thumbnail of the video generated and sent by the backend.

Changelog

  • Added thumb_url to SendFileAPIResponse types.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

Size Change: +250 B (0%)

Total Size: 304 kB

Filename Size Change
dist/browser.es.js 66.5 kB +64 B (0%)
dist/browser.js 67.2 kB +62 B (0%)
dist/index.es.js 66.5 kB +62 B (0%)
dist/index.js 67.3 kB +62 B (0%)
ℹ️ View Unchanged
Filename Size
dist/browser.full-bundle.min.js 36.5 kB

compressed-size-action

@khushal87 khushal87 marked this pull request as draft June 3, 2022 10:00
@khushal87 khushal87 force-pushed the khushal87-video-thumbnail-type branch from 0f9b6e5 to f2f7812 Compare June 3, 2022 10:11
@khushal87 khushal87 marked this pull request as ready for review June 3, 2022 10:12
@khushal87 khushal87 merged commit 79ed099 into master Jun 3, 2022
@khushal87 khushal87 deleted the khushal87-video-thumbnail-type branch June 3, 2022 10:17
@github-actions github-actions bot mentioned this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants