Skip to content

For version 1.0, make wrap default set to false (or rename) #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brettz9 opened this issue Mar 16, 2016 · 1 comment
Open

For version 1.0, make wrap default set to false (or rename) #72

brettz9 opened this issue Mar 16, 2016 · 1 comment
Labels
API
Milestone
Version 1.0

Comments

@brettz9
Copy link
Collaborator

brettz9 commented Mar 16, 2016

wrap has been set to true by default which can produce ambiguous results if the result could be either an empty array or a failure to find anything. For version 1.0, we should make this false by default.
@brettz9 brettz9 added the API label Mar 16, 2016
@brettz9 brettz9 added this to the Version 1.0 milestone Mar 16, 2016
@brettz9 brettz9 changed the title For version 1.0, make wrap default set to true For version 1.0, make wrap default set to false (or rename) Oct 20, 2018
@brettz9
Copy link
Collaborator Author

brettz9 commented Oct 20, 2018

I think I'd actually prefer to switch to a "never" option as described in #86 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
1 participant
@brettz9