Skip to content

feat(az): reverse match #6338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tleepa
Copy link

@tleepa tleepa commented Apr 2, 2025

Prerequisites

  • I have read and understood the [contributing guide][CONTRIBUTING.md].
  • The commit message follows the [conventional commits][cc] guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

This PR allows AZ segment to show information from PowerShell module first and then from Azure CLI, if the former does not exist.

@tleepa tleepa force-pushed the feat-az-reverse-match branch from 53fb88b to 17d8282 Compare April 2, 2025 12:02
@JanDeDobbeleer
Copy link
Owner

JanDeDobbeleer commented Apr 2, 2025

@tleepa there's a smarter way to go about this by only leveraging the source keyword. If you allow it to also accept a pipe split string, it could look like this by default: "source": "cli|pwsh" and use "source": "pwsh|cli" to do what you want without an additional property. That would mean that firstmatch is deprecated and needs to default to pwsh|cli

@tleepa
Copy link
Author

tleepa commented Apr 2, 2025

Frankly speaking, I am not a developer, and definitely not familiar with the go code, and I will not be able to make suggested changes.
Shall I drop this PR and raise a feature request instead?

@JanDeDobbeleer
Copy link
Owner

I'll address that here so you can have an opportunity to learn. Pretty cool you did this then though 👏🏻

@tleepa
Copy link
Author

tleepa commented Apr 2, 2025

Let's be honest this change was not the rocket science 😉
Nevertheless, I appreciate your interest in this "feature" 😄

@JanDeDobbeleer
Copy link
Owner

@all-contributors please add @tleepa for code, docs

This is pure magic 🪄! @holopin-bot @tleepa wizard

Copy link

holopin-bot bot commented Apr 3, 2025

Congratulations @tleepa, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm9136f52118260cl8arivc94h

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Copy link
Contributor

@JanDeDobbeleer

I've put up a pull request to add @tleepa! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants