Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output has too many parentheses #143

Closed
dpsanders opened this issue May 22, 2019 · 2 comments
Closed

Output has too many parentheses #143

dpsanders opened this issue May 22, 2019 · 2 comments

Comments

@dpsanders
Copy link
Member

Contractor in 1 dimensions:
  - forward pass contracts to 1 dimensions
  - variables: Symbol[Symbol("x()")]
  - expression: x()() ^ 2 - 2 * x()()

Should be x^2, not x()()^2.

cc @Yashcodes

@yashvardhan747
Copy link
Contributor

yashvardhan747 commented May 23, 2019

My output is

julia> C = Contractor(x^2 - 2*x)
Contractor in 1 dimensions:
  - forward pass contracts to 1 dimensions
  - variables: Symbol[:x]
  - expression: x() ^ 2 - 2 * x()

How's our outputs are different ?
Anyways, expression which is printed here with variables having unnecessary brackets with them is because ModelingToolkit creates expressions in this way only. I think this issue is more suited for ModelingToolkit.jl.

@dpsanders
Copy link
Member Author

No longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants