Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check sizes of arguments in dot #1167

Closed
antoine-levitt opened this issue Jan 13, 2025 · 4 comments
Closed

Check sizes of arguments in dot #1167

antoine-levitt opened this issue Jan 13, 2025 · 4 comments

Comments

@antoine-levitt
Copy link
Collaborator

JuliaLang/julia#28666 feels still relevant to me. It was not merged because it broke a few packages, but maybe if we allow dot(matrix, vector) but disallow dot(matrix, matrix) with different shapes (eg dot(randn(4,2), randn(8,1)) it's already a good step forward?
@DilumAluthge
Copy link
Member

Duplicate of #549?

(We were able to transfer the issues from JuliaLang/julia to this repo. We just couldn't automatically transfer the PRs, which is why I closed the PRs.)

@antoine-levitt
Copy link
Collaborator Author

Sorry, yes

@DilumAluthge
Copy link
Member

No worries at all.

Linking this to the main issue.

@DilumAluthge DilumAluthge reopened this Jan 14, 2025
@DilumAluthge
Copy link
Member

Duplicate of #549

@DilumAluthge DilumAluthge marked this as a duplicate of #549 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antoine-levitt @DilumAluthge