You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
log/sqrt for Symmetric/Hermitian arguments, and acos/asin/acosh for Symmetric/Hermitian arguments with Complex eltype, are type unstable. Specifically, these functions return Symmetric/Hermitian where the argument is positive semidefinite and an unannotated matrix otherwise.
Similar functions accepting, e.g., StridedMatrixs always return an unannotated matrix, even if the result internally received annotation. The question is whether the type-unstable methods above should perhaps do the same, or whether instead the type-stable methods should join the type-unstable methods in preserving annotations.
The inconsistency was surprising when working with these methods. Otherwise I see arguments for each choice.
Thoughts? Thanks!
The text was updated successfully, but these errors were encountered:
log
/sqrt
forSymmetric
/Hermitian
arguments, andacos
/asin
/acosh
forSymmetric
/Hermitian
arguments withComplex
eltype, are type unstable. Specifically, these functions returnSymmetric
/Hermitian
where the argument is positive semidefinite and an unannotated matrix otherwise.Similar functions accepting, e.g.,
StridedMatrix
s always return an unannotated matrix, even if the result internally received annotation. The question is whether the type-unstable methods above should perhaps do the same, or whether instead the type-stable methods should join the type-unstable methods in preserving annotations.The inconsistency was surprising when working with these methods. Otherwise I see arguments for each choice.
Thoughts? Thanks!
The text was updated successfully, but these errors were encountered: