Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type instability in log, sqrt, acos, asin, and acosh for symmetric/hermitian arguments #481

Open
Sacha0 opened this issue Oct 23, 2017 · 2 comments

Comments

@Sacha0
Copy link
Member

Sacha0 commented Oct 23, 2017

log/sqrt for Symmetric/Hermitian arguments, and acos/asin/acosh for Symmetric/Hermitian arguments with Complex eltype, are type unstable. Specifically, these functions return Symmetric/Hermitian where the argument is positive semidefinite and an unannotated matrix otherwise.

Similar functions accepting, e.g., StridedMatrixs always return an unannotated matrix, even if the result internally received annotation. The question is whether the type-unstable methods above should perhaps do the same, or whether instead the type-stable methods should join the type-unstable methods in preserving annotations.

The inconsistency was surprising when working with these methods. Otherwise I see arguments for each choice.

Thoughts? Thanks!

@andreasnoack
Copy link
Member

This has been discussed several times in the past so we should try to link to the relevant issues.

@fredrikekre
Copy link
Member

#21 and also some discussion in #460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants