Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LAPACK's Jacobi methods for SVD accessible #608

Closed
carstenbauer opened this issue Feb 15, 2019 · 3 comments
Closed

Make LAPACK's Jacobi methods for SVD accessible #608

carstenbauer opened this issue Feb 15, 2019 · 3 comments

Comments

@carstenbauer
Copy link
Member

In the course of JuliaLang/julia#31057, which adds a algorithm or method keyword to svd and svd!, it would be nice to have access to Jacobi methods (gesvj in LAPACK) for SVD decomposition as well.

See the discussion on discourse Calling Lapack’s Jacobi SVD - dgesvj and a draft thereout: https://gist.github.com/RalphAS/6a80a1dd4039153c8c94fc27a4938665.

Unfortunately, this is a bit above my head so I'm hoping for someone else to actually implement this. I assume this isn't really difficult if one knows what one's doing.

@andreasnoack, maybe you would be willing to take a look? I saw that you seem to have access to a gesvdj! (is this the same as gesvj?) in CuArrays.jl already.

@RalphAS
Copy link

RalphAS commented Feb 15, 2019

It's worth noting that there are also preconditioning drivers in LAPACK (with names corresponding to gejsv!). These can make the Jacobi scheme runtime-competitive with the other methods. They have rather complicated interfaces so getting the wrapper logic right may take some effort. Would it make sense to do this work in a separate package first (question for the main LinearAlgebra developers)? That would allow for more comprehensive public testing and perhaps some nice demonstrations.

@ViralBShah
Copy link
Member

Yes, a separate package definitely sounds better. Could be in JuliaLinearAlgebra org.

@RalphAS
Copy link

RalphAS commented Feb 18, 2019

Ok, here is an implementation candidate. I've refactored it a couple of times so it would be good for someone else to review for consistency.

@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants