Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transposes and adjoints of triangular matrices #774

Closed
mateuszbaran opened this issue Oct 19, 2020 · 1 comment · Fixed by JuliaLang/julia#38168
Closed

Transposes and adjoints of triangular matrices #774

mateuszbaran opened this issue Oct 19, 2020 · 1 comment · Fixed by JuliaLang/julia#38168

Comments

@mateuszbaran
Copy link
Contributor

Is there a reason why in LinearAlgebra transposes and adjoints of triangular matrices are not triangular matrices themselves? For example why transpose of an UpperTriangular matrix is not a LowerTriangular matrix that wraps transpose of the original matrix.

StaticArrays does commute these two wrappers as the issue was raised here: JuliaArrays/StaticArrays.jl#837 (comment) . Essentially all algorithms that work on triangular matrices could also work on transposes and adjoints of them but not commuting these two wrappers makes it harder to dispatch on matrices with triangular structure.

@dkarrasch
Copy link
Member

As it turns out, this is what it used to be and got changed in JuliaLang/julia#25364. In that gigantic PR, this was just a small detail and I believe there was no deeper reason to flip the order of the two lazy wrappers. I started changing it, so hopefully will have a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants