Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method resolution issue for rdiv! #783

Closed
palday opened this issue Nov 10, 2020 · 2 comments · Fixed by JuliaLang/julia#38398
Closed

Method resolution issue for rdiv! #783

palday opened this issue Nov 10, 2020 · 2 comments · Fixed by JuliaLang/julia#38398
Assignees
Labels
regression Regression in behavior compared to a previous version

Comments

@palday
Copy link
Contributor

palday commented Nov 10, 2020

The change in JuliaLang/julia#38168 causes MixedModels to fail on Julia master with a method resolution error for rdiv!:

  MethodError: no method matching rdiv!(::BlockedSparse{Float64, 1, 2}, ::UpperTriangular{Float64, Adjoint{Float64, UniformBlo
ckDiagonal{Float64}}})                                         
  Closest candidates are:
    rdiv!(::StridedMatrix{T} where T, ::UpperTriangular{var"#s814", var"#s813"} where var"#s813"<:Adjoint where var"#s814") at  ~/julia/usr/share/julia/stdlib/v1.6/LinearAlgebra/src/triangular.jl:1430
    rdiv!(::StridedMatrix{T} where T, ::UpperTriangular) at ~/julia/usr/share/julia/stdlib/v1.6/LinearAlgebra
/src/triangular.jl:1327
    rdiv!(::AbstractMatrix{T} where T, ::Transpose{var"#s826", var"#s825"} where var"#s825"<:LU where var"#s826") at ~/julia/usr/share/julia/stdlib/v1.6/LinearAlgebra/src/lu.jl:689

Tests pass again after reverting this change in a local build.

BlockedSparse is a wrapper around SparseMatrixCSC with a particular sparsity pattern. Note that this does not fall back to the generic multiplication method -- the change in order means that the second argument doesn't match the second argument in the last of the closest candidates.

@ararslan ararslan added the regression Regression in behavior compared to a previous version label Nov 10, 2020
@dkarrasch
Copy link
Member

JuliaLang/julia#38168 requires package maintainers to follow with swapping the wrappers. As I suspected in JuliaLang/julia#38168, I guess we should have done some kind of package evaluation before merging. Related error messages may look different though, depending on the specific context.

@palday
Copy link
Contributor Author

palday commented Nov 11, 2020

If package evaluation passes, I'm happy to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Regression in behavior compared to a previous version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants