Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balancing not a problem in LAPACK 3.5 #80

Closed
andreasnoack opened this issue Feb 22, 2014 · 6 comments
Closed

Balancing not a problem in LAPACK 3.5 #80

andreasnoack opened this issue Feb 22, 2014 · 6 comments
Labels
help wanted Extra attention is needed test This change adds or pertains to unit tests upstream The issue is with an upstream dependency, e.g. LLVM

Comments

@andreasnoack
Copy link
Member

When we upgrade to next version of OpenBLAS, we are also upgrading to LAPACK 3.5 in which the balancing functions xgebal have been changed. This will cause a test error because the nasty test matrix we are using now to test the effect of balancing is not nasty enough anymore. If possible we'll have to come up with a new nasty matrix.

I don't have time to look into it now so this issue is just a reminder of the problem and why the linalg tests will fail when we upgrade.

Reference: http://arxiv.org/pdf/1401.5766v1.pdf

@andreasnoack
Copy link
Member Author

As noted in JuliaLang/julia#5965 this already affects the Windows builds because they use OpenBLAS 2.9rc1.

I have tried to construct a matrix that gives wrong eigenvectors when balancing it the LAPACK 3.5 way, but I haven't succeeded.

@tkelman
Copy link

tkelman commented Feb 26, 2014

Yes, even the 0.3 prerelease Windows binaries are currently failing this test.

@jiahao
Copy link
Member

jiahao commented Jun 17, 2014

Cross-ref: #50, JuliaLang/julia#7213

@andreasnoack
Copy link
Member Author

Maybe we could turn around the test case. Since it is now impossible to choose a matrix for which balancing destroys the eigen calculation we choose a matrix that is poorly handled without balancing and check that instead.

@jiahao
Copy link
Member

jiahao commented Jun 17, 2014

Yes, that is probably easier.

@andreasnoack
Copy link
Member Author

The code path is tested so I'm closing.

@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed test This change adds or pertains to unit tests upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Development

No branches or pull requests

3 participants