-
-
Notifications
You must be signed in to change notification settings - Fork 273
Specifying registries needed for a project in the Project file #3845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't have much of an opinion on how exactly the data is stored, but IMO having the UUID doesn't really cost us all that much but is a gain UX wise. We should already check for uniqueness when doing
I think so, yeah. Without that information, the project is still not instantiable from just Project.toml alone. Making |
Copying what I just posted in Slack here:
Hm, my gut went with asking before adding the registry, but maybe auto-adding is fine.
We could make it follow the same semantics as a Pkg.
|
Until we have a satisfactory solution to #2393 (dependency confusion), I'd be wary of adding registries without confirmation. |
From #3783 (comment)
[sources]
made it easier to resolve a manifest with unregistered dependencies without having to manually add these dependencies by URL. However, you still need to make sure that the registries are available. So the next step would be to store the set of registries needed in the project file as well so that they are automatically installed for you.This issue is about how to specify that information in the project file.
The first question is if we need to store the UUID of the registry somewhere. It's kind of silly since there are so few registries. If we then only look at the registry name we could have:
or maybe this should be a dict and be
Should custom registries be auto-added to the project file once a package is added to the project that is not available in general?
cc @ericphanson, @Seelengrab
The text was updated successfully, but these errors were encountered: