Skip to content

Commit 30399e5

Browse files
committed
Use the official required kwarg form
I forgot this existed
1 parent 73933f5 commit 30399e5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

base/abstractarraymath.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ julia> squeeze(a; dims=3)
6464
2 4
6565
```
6666
"""
67-
squeeze(A; dims=throw(ArgumentError("the dimensions to squeeze must be specified with a `dims` keyword argument"))) = _squeeze(A, dims)
67+
squeeze(A; dims) = _squeeze(A, dims)
6868
function _squeeze(A::AbstractArray, dims::Dims)
6969
for i in 1:length(dims)
7070
1 <= dims[i] <= ndims(A) || throw(ArgumentError("squeezed dims must be in range 1:ndims(A)"))

test/arrayops.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ end
240240
@test @inferred(squeeze(a, dims=1)) == @inferred(squeeze(a, dims=(1,))) == reshape(a, (1, 8, 8, 1))
241241
@test @inferred(squeeze(a, dims=(1, 5))) == squeeze(a, dims=(5, 1)) == reshape(a, (1, 8, 8))
242242
@test @inferred(squeeze(a, dims=(1, 2, 5))) == squeeze(a, dims=(5, 2, 1)) == reshape(a, (8, 8))
243-
@test_throws ArgumentError squeeze(a)
243+
@test_throws UndefKeywordError squeeze(a)
244244
@test_throws ArgumentError squeeze(a, dims=0)
245245
@test_throws ArgumentError squeeze(a, dims=(1, 1))
246246
@test_throws ArgumentError squeeze(a, dims=(1, 2, 1))

0 commit comments

Comments
 (0)