Test partition with UTF8 string per

#15409 (comment)

remove FIXMEs per
#15409 (comment)

Author: samoconnor

base/iterator.jl

@@ -481,11 +481,8 @@ julia> collect(partition([1,2,3,4,5], 2))
  [5]
 ```
 """
-function partition{T}(c::T, n::Int)
-    # FIXME Use @require per https://github.com/JuliaLang/julia/pull/15495
-    @assert n > 0
-    return PartitionIterator{T}(c, n)
-end
+partition{T}(c::T, n::Int) = PartitionIterator{T}(c, n)
+
 
 type PartitionIterator{T}
     c::T

base/pmap.jl

@@ -61,7 +61,6 @@ Equivalent to `partition(c, max_batch_size)` when `length(c) >> max_batch_size`.
 """
 function batchsplit(c; min_batch_count=1, max_batch_size=100)
 
-    # FIXME Use @require per https://github.com/JuliaLang/julia/pull/15495
     @assert min_batch_count > 0
     @assert max_batch_size > 1
 

test/functional.jl

@@ -269,8 +269,19 @@ for n in [5,6]
 end
 
 
-@test_throws AssertionError Base.partition([1,2,3,4,5], 0)
-@test_throws AssertionError Base.partition([1,2,3,4,5], -1)
-
 @test join(map(x->string(x...), Base.partition("Hello World!", 5)), "|") ==
       "Hello| Worl|d!"
+
+let s = "Monkey 🙈🙊🙊"
+    tf = (n)->join(map(x->string(x...), Base.partition(s,n)), "|")
+    @test tf(10) == s
+    @test tf(9) == "Monkey 🙈🙊|🙊"
+    @test tf(8) == "Monkey 🙈|🙊🙊"
+    @test tf(7) == "Monkey |🙈🙊🙊"
+    @test tf(6) == "Monkey| 🙈🙊🙊"
+    @test tf(5) == "Monke|y 🙈🙊🙊"
+    @test tf(4) == "Monk|ey 🙈|🙊🙊"
+    @test tf(3) == "Mon|key| 🙈🙊|🙊"
+    @test tf(2) == "Mo|nk|ey| 🙈|🙊🙊"
+    @test tf(1) == "M|o|n|k|e|y| |🙈|🙊|🙊"
+end