make sure we error on build if a package fails to build (#298)

Author: KristofferC

stdlib/Pkg/src/Operations.jl

@@ -843,6 +843,7 @@ function build_versions(ctx::Context, uuids::Vector{UUID}; might_need_to_resolve
     sort!(builds, by = build -> order[first(build)])
     max_name = isempty(builds) ? 0 : maximum(textwidth.([build[2] for build in builds]))
     # build each package verions in a child process
+    build_succeeded = true
     for (uuid, name, hash_or_path, build_file) in builds
         log_file = splitext(build_file)[1] * ".log"
         printpkgstyle(ctx, :Building,
@@ -861,16 +862,24 @@ function build_versions(ctx::Context, uuids::Vector{UUID}; might_need_to_resolve
             --compiled-modules=$(Bool(Base.JLOptions().use_compiled_modules) ? "yes" : "no")
             --eval $code
             ```
-        run_build = () -> begin
-            open(log_file, "w") do log
+        run_build = () ->begin
+            ok = open(log_file, "w") do log
                 success(pipeline(cmd, stdout=log, stderr=log))
-            end ? Base.rm(log_file, force=true) :
+            end
+            if ok
+                Base.rm(log_file, force=true)
+            else
                 @error("Error building `$name`; see log file for further info")
+                build_succeeded = false
+            end
         end
         with_dependencies_loadable_at_toplevel(ctx, PackageSpec(name, uuid); might_need_to_resolve=might_need_to_resolve) do
             run_build()
         end
     end
+    if !build_succeeded
+        cmderror("at least one package failed to build")
+    end
     return
 end
 

stdlib/Pkg/test/pkg.jl

@@ -180,6 +180,23 @@ temp_pkg_dir() do project_path
             end
         end
     end
+
+    @testset "failing building a package should throw" begin
+        mktempdir() do path
+            try
+                cd(path) do
+                    pushfirst!(LOAD_PATH, Base.parse_load_path("@"))
+                    Pkg.generate("FailBuildPkg")
+                    cd("FailBuildPkg") do
+                        write_build(pwd(), "error()")
+                        @test_throws CommandError Pkg.build()
+                    end
+                end
+            finally
+                popfirst!(LOAD_PATH)
+            end
+        end
+    end
 end
 
 temp_pkg_dir() do project_path

stdlib/Pkg/test/utils.jl

@@ -34,3 +34,9 @@ function cd_tempdir(f)
 end
 
 isinstalled(pkg) = Base.locate_package(Base.PkgId(pkg.uuid, pkg.name)) !== nothing
+
+function write_build(path, content)
+    build_filename = joinpath(path, "deps", "build.jl")
+    mkpath(dirname(build_filename))
+    write(build_filename, content)
+end