deprecate float64_isvalid, float32_isvalid

Author: tanmaykm

base/deprecated.jl

@@ -477,3 +477,19 @@ function to_index{T<:Real}(A::AbstractArray{T})
     depwarn("indexing with non Integer AbstractArrays is deprecated", :to_index)
     Int[to_index_nodep(x) for x in A]
 end
+
+function float_isvalid{T<:Union(Float32,Float64)}(s::AbstractString, out::Array{T,1})
+    tf = tryparse(T, s)
+    isnull(tf) || (out[1] = get(tf))
+    !isnull(tf)
+end
+
+function float32_isvalid(s::AbstractString, out::Array{Float32,1})
+    depwarn("float32_isvalid is deprecated, use tryparse(Float32,s) instead", :float32_isvalid)
+    float_isvalid(s, out)
+end
+
+function float64_isvalid(s::AbstractString, out::Array{Float64,1})
+    depwarn("float64_isvalid is deprecated, use tryparse(Float64,s) instead", :float64_isvalid)
+    float_isvalid(s, out)
+end

base/string.jl

@@ -1638,15 +1638,6 @@ parsefloat(x::AbstractString) = parse(Float64,x)
 
 float{S<:AbstractString}(a::AbstractArray{S}) = map!(float, similar(a,typeof(float(0))), a)
 
-function float_isvalid{T<:Union(Float32,Float64)}(s::AbstractString, out::Array{T,1})
-    tf = tryparse(T, s)
-    isnull(tf) || (out[1] = get(tf))
-    !isnull(tf)
-end
-
-float32_isvalid(s::AbstractString, out::Array{Float32,1}) = float_isvalid(s, out)
-float64_isvalid(s::AbstractString, out::Array{Float64,1}) = float_isvalid(s, out)
-
 # find the index of the first occurrence of a value in a byte array
 
 typealias ByteArray Union(Array{UInt8,1},Array{Int8,1})