🎉 at-deprecate ones 🎉

Author: fredrikekre

NEWS.md

@@ -534,6 +534,11 @@ Deprecated or removed
     and/or shape depending on `opts...`. For an algebraic multiplicative identity,
     consider `one(A)` ([#24656]).
 
+  * `ones(dims...)` `and ones(T, dims)` have been deprecated. The replacements are
+    `fill(1.0, dims...)` and `fill(one(T), dims...)`, but other common patterns, such as
+    `x*ones(dims)` for some value `x` can, with advantage, instead be rewritten as
+    `fill(x, dims)` ([#TBD]).
+
   * The `Operators` module is deprecated. Instead, import required operators explicitly
     from `Base`, e.g. `import Base: +, -, *, /` ([#22251]).
 

base/array.jl

@@ -353,34 +353,10 @@ julia> zeros(Int8, 2, 3)
 """
 function zeros end
 
-"""
-    ones([T=Float64,] dims...)
-
-Create an `Array`, with element type `T`, of all ones with size specified by `dims`.
-See also [`zeros`](@ref), [`similar`](@ref).
-
-# Examples
-```jldoctest
-julia> ones(1,2)
-1×2 Array{Float64,2}:
- 1.0  1.0
-
-julia> ones(ComplexF64, 2, 3)
-2×3 Array{Complex{Float64},2}:
- 1.0+0.0im  1.0+0.0im  1.0+0.0im
- 1.0+0.0im  1.0+0.0im  1.0+0.0im
-```
-"""
-function ones end
-
-for (fname, felt) in ((:zeros, :zero), (:ones, :one))
-    @eval begin
-        $fname(::Type{T}, dims::NTuple{N, Any}) where {T, N} = fill!(Array{T,N}(uninitialized, Dims(dims)), $felt(T))
-        $fname(dims::Tuple) = ($fname)(Float64, dims)
-        $fname(::Type{T}, dims...) where {T} = $fname(T, dims)
-        $fname(dims...) = $fname(dims)
-    end
-end
+zeros(::Type{T}, dims::NTuple{N, Any}) where {T, N} = fill!(Array{T,N}(uninitialized, Dims(dims)), zero(T))
+zeros(dims::Tuple) = (zeros)(Float64, dims)
+zeros(::Type{T}, dims...) where {T} = zeros(T, dims)
+zeros(dims...) = zeros(dims)
 
 function _one(unit::T, x::AbstractMatrix) where T
     m,n = size(x)

base/deprecated.jl

@@ -1725,6 +1725,12 @@ end
 @deprecate zeros(a::AbstractArray, ::Type{T}) where {T}               fill!(similar(a, T), 0)
 @deprecate zeros(a::AbstractArray)                                    fill!(similar(a), 0)
 
+# deprecate ones
+@deprecate ones(::Type{T}, dims::Tuple) where {T} fill(one(T), dims)
+@deprecate ones(dims::Tuple) fill(1., dims)
+@deprecate ones(::Type{T}, dims...) where {T} fill(one(T), dims...)
+@deprecate ones(dims...) fill(1., dims...)
+
 # PR #23711
 @eval LibGit2 begin
     @deprecate get_creds!(cache::CachedCredentials, credid, default) get!(cache, credid, default)

base/exports.jl

@@ -476,7 +476,6 @@ export
     minmax,
     ndims,
     nonzeros,
-    ones,
     parent,
     parentindexes,
     partialsort,