Skip to content

Commit d78502d

Browse files
committed
Make workspace larger in xbdsdc to avoid segfault when uplo='L'.
1 parent 550896d commit d78502d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

base/linalg/lapack.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -2067,7 +2067,7 @@ for (bdsdc, elty) in
20672067
validate(uplo)
20682068
n, ldiq, ldq, ldu, ldvt = length(d), 1, 1, 1, 1
20692069
if compq == 'N'
2070-
lwork = 4n
2070+
lwork = 6n
20712071
elseif compq == 'P'
20722072
warn("COMPQ='P' is not tested")
20732073
#TODO turn this into an actual LAPACK call

test/linalg.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ for elty in (Float32, Float64, Complex64, Complex128)
476476
#XXX If I run either of these tests separately, by themselves, things are OK.
477477
# Enabling BOTH tests results in segfault.
478478
# Where is the memory corruption???
479-
#@test_approx_eq svdvals(full(T)) svdvals(T)
479+
@test_approx_eq svdvals(full(T)) svdvals(T)
480480
u1, d1, v1 = svd(full(T))
481481
u2, d2, v2 = svd(T)
482482
@test_approx_eq d1 d2

0 commit comments

Comments
 (0)