fix #25724, overly-aggressive removal of Newvar nodes with x = x in try block (#25838)

Author: JeffBezanson

Diff for: src/julia-syntax.scm

@@ -4005,7 +4005,7 @@ f(x) = yt(x)
                      (if (has? vars (cadr e))
                          (begin (del! vars (cadr e))
                                 (put! di (cadr e) #t))))
-                    ((and (pair? e) (memq (car e) '(goto gotoifnot)))
+                    ((and (pair? e) (memq (car e) '(goto gotoifnot enter)))
                      (set! vars (table)))))
             (loop (cdr stmts)))))))
 

Diff for: test/core.jl

@@ -3185,6 +3185,23 @@ function f11065()
 end
 @test_throws UndefVarError f11065()
 
+# issue #25724
+a25724 = Any[]
+for i = 1:3
+    needX = false
+    try
+        X = X
+        X[1] = X[1] + 1
+    catch err
+        needX = true
+    end
+    if needX
+        X = [0]
+    end
+    push!(a25724, copy(X))
+end
+@test a25724 == [[0], [0], [0]]
+
 # for loop iterator expression should be evaluated in outer scope
 let
     for i in (local a = 1:2)