We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 4e63b89 commit e5c8309Copy full SHA for e5c8309
base/linalg/diagonal.jl
@@ -338,9 +338,9 @@ svdvals(D::Diagonal) = [svdvals(v) for v in D.diag]
338
function svd{T<:Number}(D::Diagonal{T})
339
S = abs.(D.diag)
340
piv = sortperm(S, rev = true)
341
- U = Array(Diagonal(D.diag ./ S))
+ U = Diagonal(D.diag ./ S)
342
Up = hcat([U[:,i] for i = 1:length(D.diag)][piv]...)
343
- V = eye(D)
+ V = Diagonal(ones(D.diag))
344
Vp = hcat([V[:,i] for i = 1:length(D.diag)][piv]...)
345
return (Up, S[piv], Vp)
346
end
0 commit comments