Skip to content

Commit ee651f4

Browse files
precompilepkgs: report direct dep ext errors (#54741)
1 parent 67001d6 commit ee651f4

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

base/precompilation.jl

+8-4
Original file line numberDiff line numberDiff line change
@@ -385,10 +385,6 @@ function precompilepkgs(pkgs::Vector{String}=String[];
385385
hascolor = get(io, :color, false)::Bool
386386
color_string(cstr::String, col::Union{Int64, Symbol}) = _color_string(cstr, col, hascolor)
387387

388-
direct_deps = [
389-
Base.PkgId(uuid, name)
390-
for (name, uuid) in env.project_deps if !Base.in_sysimage(Base.PkgId(uuid, name))
391-
]
392388
stale_cache = Dict{StaleCacheKey, Bool}()
393389
exts = Dict{Base.PkgId, String}() # ext -> parent
394390
# make a flat map of each dep and its direct deps
@@ -428,6 +424,14 @@ function precompilepkgs(pkgs::Vector{String}=String[];
428424
end
429425
end
430426

427+
direct_deps = [
428+
Base.PkgId(uuid, name)
429+
for (name, uuid) in env.project_deps if !Base.in_sysimage(Base.PkgId(uuid, name))
430+
]
431+
432+
# consider exts of direct deps to be direct deps so that errors are reported
433+
append!(direct_deps, keys(filter(d->last(d) in keys(env.project_deps), exts)))
434+
431435
# An extension effectively depends on another extension if it has all the the
432436
# dependencies of that other extension
433437
function expand_dependencies(depsmap)

0 commit comments

Comments
 (0)